[gabriellsh]

Proposed changes (including videos or screenshots)

Adds the message variants to @rocket.chat/ui-message-list (RoomMessage, SystemMessage, ThreadMessage, ThreadMessagePreview, the header, roles, avatar, status and receipt parts, and the hooks and libs they use) and switches every consumer to them: the old room and thread lists, the pinned, starred and mentions tabs, search, the audit, and the threads list. It deletes apps/meteor/client/components/message/**, MessageListContext and MessageListProvider; lib/MessageAction.ts becomes a re-export of the package's types. MessagesProvider gains the editing context, the selection adapter and the data the variants read about a conversation.

Twenty-five commits. Five fixes sit at the bottom, each with a changeset and a spec that fails first; then enabling steps (roles resolved once per place, the editing context fed from the highlight store); then the package variants in three commits, the consumer switches, the deletions and docs. The old lists stay until parts 08 and 09 of the stack, so their jump highlight still comes through the shared highlight store, and the old room list registers what it renders for "Select all" through the rows themselves.

The specs develop added or changed in #43386 for RoomMessage and SystemMessage are ported to the package's specs of those variants.

This is part 06 of the stack (00 to 09). Review it against its base branch message-list/05-toolbar, not against develop.

Stack

• 00 chore(ui-message-list): add the spec-first ui-message-list package: chore(ui-message-list): add the spec-first ui-message-list package #43721
• 01 refactor: move message helpers to where the new list needs them: refactor: move message helpers to where the new list needs them #43722
• 02 fix: correct six defects of the room and thread message lists: fix: correct six defects of the room and thread message lists #43723
• 03 feat(ui-message-list): add message contexts and content parts: feat(ui-message-list): add message contexts and content parts #43724
• 04 feat(ui-message-list): add message attachments: feat(ui-message-list): add message attachments #43725
• 05 feat(ui-message-list): add the message toolbar: feat(ui-message-list): add the message toolbar #43726
• 06 feat(ui-message-list): add the message variants, delete the app copies: feat(ui-message-list): add the message variants, delete the app copies #43727 ← this PR
• 07 feat(ui-message-list): add the message list engine: feat(ui-message-list): add the message list engine #43728
• 08 feat: render the room's messages with the ui-message-list list: feat: render the room's messages with the ui-message-list list #43729
• 09 feat: render thread messages with ui-message-list, remove old lists: feat: render thread messages with ui-message-list, remove old lists #43730

Visible changes

• .changeset/audit-messages-follow-display-settings.md, '@rocket.chat/meteor': minor: the audit shows the time, the roles, the username beside the real name when real names are on, read receipts and URL previews, as the viewer's settings say.
• .changeset/thread-avatar-click-stays-in-the-message.md, '@rocket.chat/meteor': patch: the user info no longer closes right after it opens from a thread message's avatar.
• .changeset/messages-draw-no-stray-zero.md, '@rocket.chat/meteor': patch: no stray "0" under a message with empty action links or reactions.
• .changeset/broadcast-reply-hidden-where-interaction-is-off.md, '@rocket.chat/meteor': patch: no broadcast reply button where messages cannot be acted on, such as the audit.
• .changeset/edited-message-date-follows-date-format.md, '@rocket.chat/meteor': patch: the tooltip of the "edited" indicator uses the viewer's date and time format.
• .changeset/message-toolbar-uses-the-room-of-the-message.md, '@rocket.chat/meteor': patch: the toolbar of a message found by search in all rooms uses the message's own room, not the open one.

Known differences from develop

The changes above, and:

• a place that allows no interaction shows no editing look;
• the showUserAvatar prop is removed;
• a conversation is answered from the place's room without a per-message query.

The package records eight behaviors carried over from develop as pinned defects (skipped tests): D2 a revealed ignored message is hidden again when its row remounts; D3 activating the checkbox input toggles twice; D4 a thread preview has no per-message fallback; D5 Space on a thread preview does not prevent the default; D6 a pending encrypted message in a thread keeps its toolbar; D7 system and thread messages have no accessible name; D8 the preview of a reply to a system message writes the text from the reply. D1 (a jump replaces the editing look) is retired in part 09 of the stack.

Issue(s)

Steps to test or reproduce

• Room: selection mode, select with click and with Space, "Select all" scrolls up and selects, export the selection.
• Ignore a user and reveal one message.
• Edit a message (editing look); open a ?msg= link (highlight).
• In an E2EE room: a pending message.
• A thread with unread replies, mentions and @all markers.
• The pinned, starred and mentions tabs, and search: a result from another room has the toolbar of its own room.
• Audit: no toolbar, no broadcast reply, times, roles and read receipts as the settings say.
• The threads list: follow and unfollow.
• Click a thread message's avatar: the user info stays open.
• Hover the "edited" indicator: the date follows the date format setting.
• Keyboard focus into and out of a message's toolbar.
• Message headers with roles, in a room with many authors.

Further comments

Decisions to check

• The refactor 349d4cc7d1f sits above two feature commits (b4ce5b8bd88, 1ea07c37ad7). Moving it down conflicted in MessagesProvider.spec.tsx, so the order was left.
• In the audit each header still resolves roles itself: one request per room, one roles-change listener per row. Resolving once per place there needs a multi-room resolution in MessagesProvider, a design change outside the approved spec.
• message-toolbar R25 was amended: a pending encrypted message in a thread keeps its toolbar (D6).
• The thread body id <mid>-content is dropped, as on develop, so it is not duplicated when the thread panel is open.
• The related-data value changes on every room or subscription update, as develop's did; part 08 of the stack makes it stable.
• Changesets for @rocket.chat/ui-message-list. This PR adds none for the private package; parts 08 and 09 of the stack do. The repo versions private packages (other private packages carry changesets), so 08 and 09 follow the repo, and 03 to 07 may need changesets too. Undecided.

Not run

• The e2e suites, and the app in a browser.
• Checks ran on the branch tip only, not commit by commit.
• The roles of a room an auditor is not in cannot be fetched; the header renders without roles (spec R52), checked by a spec only.

🤖 Generated with Claude Code

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is still a draft
• This PR is missing the 'stat: QA assured' label
• This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: bb86c64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@rocket.chat/meteor	Minor
@rocket.chat/core-typings	Minor
@rocket.chat/rest-typings	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[codecov]

Codecov Report

❌ Patch coverage is 90.28290% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.57%. Comparing base (b743403) to head (bb86c64).

Additional details and impacted files

@@                     Coverage Diff                     @@
##           message-list/05-toolbar   #43727      +/-   ##
===========================================================
+ Coverage                    71.53%   71.57%   +0.03%     
===========================================================
  Files                         5765     5632     -133     
  Lines                       253313   251970    -1343     
  Branches                     47920    47469     -451     
===========================================================
- Hits                        181212   180350     -862     
+ Misses                       67679    67288     -391     
+ Partials                      4422     4332      -90     

Flag	Coverage Δ
e2e	62.99% <81.15%> (-0.04%)	⬇️
e2e-api	49.49% <ø> (-0.28%)	⬇️
unit	70.53% <90.48%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.