[gabriellsh]

Proposed changes (including videos or screenshots)

Adds the message attachment components to @rocket.chat/ui-message-list (file, image, audio, video, generic, encrypted download, PDF, quote, default and action attachments, the map) and the media value of MessagesProvider: the shared audio player, downloads through the service worker, the encrypted PDF opener and the desktop document viewer. Every consumer switches to the package parts and the app's copies are deleted: the room, thread and system message variants, the forward, pin and report dialogs, the composer's quote, contact history, moderation, the share-location modal and MediaPlayerProvider.

Twelve commits. The first two code commits sit below the feature: a fix (downloading an encrypted file a second time) and a refactor of the encrypted PDF opener, which now keeps one blob, one request and one download id per file even though the provider shares the opener.

Spacing in the package's attachments uses the spacing scale tokens, except two 2px values: the bottom margin of AttachmentRow and the gap of a row in DefaultAttachment. Their entries in scripts/spacing-scale/baseline.json move from the app paths to the package paths; the entries of the other deleted app attachments go. The spec develop added in #43386 for the action attachment's mutation moves into the package.

This is part 04 of the stack (00 to 09). Review it against its base branch message-list/03-contexts-and-content, not against develop.

Stack

• 00 chore(ui-message-list): add the spec-first ui-message-list package: chore(ui-message-list): add the spec-first ui-message-list package #43721
• 01 refactor: move message helpers to where the new list needs them: refactor: move message helpers to where the new list needs them #43722
• 02 fix: correct six defects of the room and thread message lists: fix: correct six defects of the room and thread message lists #43723
• 03 feat(ui-message-list): add message contexts and content parts: feat(ui-message-list): add message contexts and content parts #43724
• 04 feat(ui-message-list): add message attachments: feat(ui-message-list): add message attachments #43725 ← this PR
• 05 feat(ui-message-list): add the message toolbar: feat(ui-message-list): add the message toolbar #43726
• 06 feat(ui-message-list): add the message variants, delete the app copies: feat(ui-message-list): add the message variants, delete the app copies #43727
• 07 feat(ui-message-list): add the message list engine: feat(ui-message-list): add the message list engine #43728
• 08 feat: render the room's messages with the ui-message-list list: feat: render the room's messages with the ui-message-list list #43729
• 09 feat: render thread messages with ui-message-list, remove old lists: feat: render thread messages with ui-message-list, remove old lists #43730

Visible changes

.changeset/encrypted-attachment-downloads-again.md, '@rocket.chat/meteor': patch: an encrypted file can be downloaded a second time from the same button, in a message and in the room's files list. Before, only the first download saved the file.

Known differences from develop

• The encrypted PDF opener keeps the five most recent blobs. A blob can be released while its viewer still shows it, once five newer files are opened.
• The audio control can lag the shared player by one frame. Only audio attachments render again with the player's progress.
• Quoted messages keep the app's current hover styling.

Issue(s)

Steps to test or reproduce

In a room:

• an image, a video, an audio message, a generic file, a markdown file, a PDF, a quote with nested attachments, and a file in an E2EE room;
• play audio, switch rooms, and confirm it keeps playing in the sidebar card;
• collapse an image, scroll it away and back: it stays collapsed;
• download an encrypted file twice from the same button;
• open an encrypted PDF (the desktop viewer when it is there, a download otherwise).

Elsewhere:

• forward, pin and report a message with an attachment (no toolbar in these dialogs);
• quote a message with an attachment in the composer;
• open the contact history of an omnichannel contact with files;
• open a reported message in moderation;
• share a location.

Further comments

Decisions to check

• Two 2px attachment values. AttachmentRow's bottom margin and the row gap in DefaultAttachment stay 2px, as on develop, with entries in the spacing scale baseline instead of a token.
• Changesets for @rocket.chat/ui-message-list. This PR adds none for the private package; parts 08 and 09 of the stack do. The repo versions private packages (other private packages carry changesets), so 08 and 09 follow the repo, and 03 to 07 may need changesets too. Undecided.

Not run

• The e2e suites, and the app in a browser.
• Checks ran on the branch tip only, not commit by commit.
• The moderation and contact-history mounts are covered only by this manual pass.

🤖 Generated with Claude Code

[changeset-bot]

🦋 Changeset detected

Latest commit: dc00db2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is still a draft
• This PR is missing the 'stat: QA assured' label
• This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[codecov]

Codecov Report

❌ Patch coverage is 90.88146% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.48%. Comparing base (5917e63) to head (dc00db2).

Additional details and impacted files

@@                           Coverage Diff                            @@
##           message-list/03-contexts-and-content   #43725      +/-   ##
========================================================================
+ Coverage                                 71.30%   71.48%   +0.17%     
========================================================================
  Files                                      5624     5618       -6     
  Lines                                    250477   250864     +387     
  Branches                                  46723    46990     +267     
========================================================================
+ Hits                                     178606   179327     +721     
+ Misses                                    67493    67190     -303     
+ Partials                                   4378     4347      -31     

Flag	Coverage Δ
e2e	63.11% <53.73%> (+0.10%)	⬆️
e2e-api	49.49% <ø> (+0.03%)	⬆️
unit	70.39% <90.88%> (+0.26%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.