[gabriellsh]

Proposed changes (including videos or screenshots)

Adds the message toolbar to @rocket.chat/ui-message-list: the inline actions (reaction with quick reactions, quote, reply in thread, forward, jump), the action menu, the AI menu, the item sets for the eleven contexts, and the visibility rule that keeps the toolbar shown while its menu or the emoji picker is open. MessagesProvider gains the toolbar value, which runs the app's menu action hooks and appends the apps' actions. The app's components/message/toolbar/** is deleted.

@rocket.chat/ui-emoji-picker gains addFrequentEmoji, so a quick reaction can count toward the frequent emoji without being added to the recent list (the package is private, no changeset). A refactor below the feature makes the read receipts action take its settings as a parameter.

Where no chat is open, the provider says the place offers no reactions (useQuickReactions returns undefined), so the toolbar shows no reaction item there, as develop's toolbar showed none. The specs develop added in #43386 for the reaction action are merged into the package's and the provider's specs.

This is part 05 of the stack (00 to 09). Review it against its base branch message-list/04-attachments, not against develop.

Stack

• 00 chore(ui-message-list): add the spec-first ui-message-list package: chore(ui-message-list): add the spec-first ui-message-list package #43721
• 01 refactor: move message helpers to where the new list needs them: refactor: move message helpers to where the new list needs them #43722
• 02 fix: correct six defects of the room and thread message lists: fix: correct six defects of the room and thread message lists #43723
• 03 feat(ui-message-list): add message contexts and content parts: feat(ui-message-list): add message contexts and content parts #43724
• 04 feat(ui-message-list): add message attachments: feat(ui-message-list): add message attachments #43725
• 05 feat(ui-message-list): add the message toolbar: feat(ui-message-list): add the message toolbar #43726 ← this PR
• 06 feat(ui-message-list): add the message variants, delete the app copies: feat(ui-message-list): add the message variants, delete the app copies #43727
• 07 feat(ui-message-list): add the message list engine: feat(ui-message-list): add the message list engine #43728
• 08 feat: render the room's messages with the ui-message-list list: feat: render the room's messages with the ui-message-list list #43729
• 09 feat: render thread messages with ui-message-list, remove old lists: feat: render thread messages with ui-message-list, remove old lists #43730

Visible changes

• .changeset/message-toolbar-menu-with-only-app-actions.md, '@rocket.chat/meteor': minor: the "More" menu shows when it holds only actions added by apps; before, it was hidden when no built-in action applied.
• .changeset/message-toolbar-quick-reactions-not-recent.md, '@rocket.chat/meteor': minor: a reaction picked from the quick reactions is no longer added to the recently used emoji; it still counts toward the frequently used emoji that choose the quick reactions, and the emoji picker still does both.

Known differences from develop

Besides the two above:

• hovering a quick reaction no longer previews it in an open emoji picker (not in a changeset);
• the toolbar hold is taken before the picker opens, where develop takes it after (a keyboard-only edge case).

Issue(s)

Steps to test or reproduce

Hover a message in each of: a room, a thread, a DM, the pinned, starred and mentions tabs, search results, and a federated room if available. Compare the inline items and the menu with develop.

• react from the quick reactions and from the picker; a picker pick appears in Recent, a quick reaction does not, and both re-rank the frequent emoji;
• quote, reply in thread, forward;
• copy the link, pin, star, mark unread, edit, delete, report;
• open read receipts with read receipts enabled;
• run an app action with an app installed, and check a menu that holds only app actions;
• open the picker from the keyboard and confirm the toolbar stays shown, and is released when the picker closes;
• audit, contact history and the dialogs show no toolbar.

Further comments

Decisions to check

• Unresolved: useCountQuickReaction reads the emoji picker context inside each reaction action, so every on-screen toolbar's reaction action re-renders on each picker preview and frequency change. develop did the same, and the spec's "nothing below renders again" is not accurate for it.
• The reaction item where no chat is open. It is hidden there, as on develop. develop's quote action and toolbar holder also show nothing without a chat; the package's quote action and holder do not check for a chat, and this PR leaves them so.
• Changesets for @rocket.chat/ui-message-list. This PR adds none for the private package (nor for the private @rocket.chat/ui-emoji-picker); parts 08 and 09 of the stack add some for @rocket.chat/ui-message-list. The repo versions private packages (other private packages carry changesets), so 08 and 09 follow the repo, and 03 to 07 may need changesets too. Undecided.

Not run

• The e2e suites, and the app in a browser.
• Checks ran on the branch tip only, not commit by commit.
• The menus of message-mobile and search and the read-only and muted gates on menu entries are not exercised by specs of their own.

🤖 Generated with Claude Code

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is still a draft
• This PR is missing the 'stat: QA assured' label
• This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[changeset-bot]

🦋 Changeset detected

Latest commit: b743403

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@rocket.chat/meteor	Minor
@rocket.chat/core-typings	Minor
@rocket.chat/rest-typings	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

❌ Patch coverage is 92.11823% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.61%. Comparing base (dc00db2) to head (b743403).

Additional details and impacted files

@@                       Coverage Diff                       @@
##           message-list/04-attachments   #43726      +/-   ##
===============================================================
+ Coverage                        71.41%   71.61%   +0.20%     
===============================================================
  Files                             5726     5623     -103     
  Lines                           252065   251728     -337     
  Branches                         47359    47464     +105     
===============================================================
+ Hits                            180016   180285     +269     
+ Misses                           67647    67090     -557     
+ Partials                          4402     4353      -49     

Flag	Coverage Δ
e2e	63.12% <77.41%> (+0.10%)	⬆️
e2e-api	49.74% <ø> (-0.02%)	⬇️
unit	70.56% <92.11%> (+0.16%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.