Repository navigation
test(ci): split the looping live-images tests to fit the unit budget - #14764
Merged
Merged
Conversation
live_images_import_cached_layers_and_save_them_only_when_ci_asks ran three full live-images builds in one test and took 8.3 s on linux_amd64, over the unit partition's 8 s per-test budget; the failed-build test looped the same way at 5.2 s. Give each case its own test, sharing the checks through a helper, so each runs one build. Signed-off-by: Carlos Villela <cvillela@nvidia.com>
cv
enabled auto-merge (squash)
November 22, 2026 00:54
Collaborator
Author
|
The over-budget failure this fixes: linux_amd64 / Unit tests 2 of 2 on #14763, where the test took 8.3 s against the 8 s limit. Run locally, the split tests take 1.2 to 2.5 s each. |
Contributor
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-14764.docs.buildwithfern.com/nemoclaw |
This was referenced Nov 22, 2026
Collaborator
Author
Authoring session — opening
|
Contributor
Selected hardware E2EsCommit: Selected cases run automatically; results do not gate merging. Shared code or test infrastructure changed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits two looping live-images tests in
nemoclaw-build's CI lifecycle suite into one test per case, so each stays within the unit partition's 8 s per-test budget.Problem
ci_lifecycle::live_images_import_cached_layers_and_save_them_only_when_ci_asksruns three fulllive-imagesfixture builds, one perNEMOCLAW_SAVE_GHA_CACHEsetting, and took 8.3 s on linux_amd64, over the 8 s per-test budget in.config/test-budgets.yaml.live_images_report_failed_build_duration_and_stoploops over the three images the same way and took 5.2 s.Change