Repository navigation
ci(release): notarize macOS in the tag-only release-signing environment - #14762
Merged
Merged
Conversation
Run the macOS notarization job in the release-signing environment, whose deployment rule admits only v0.1.* tags, so the Apple notary credentials are environment secrets rather than repository secrets any branch's workflow could read. The 3S job stays outside the environment so its Vault identity remains bound to the tag. Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-14762.docs.buildwithfern.com/nemoclaw |
Contributor
Selected hardware E2EsCommit: Selected cases run automatically; results do not gate merging. Shared code or test infrastructure changed.
|
Collaborator
Author
Authoring session — opening
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sign-macosjob (Apple notarization) in therelease-signingenvironment. That environment's deployment rule admits onlyv0.1.*tags, soAPPLE_NOTARY_IDandAPPLE_NOTARY_PASSWORDcan be environment secrets instead of repository secrets that any branch's workflow could read.sign-macos-3soutside the environment: an environment changes the OIDCsubclaim, and Vault'snemoclaw-release-signingrole is bound to the tag identity.internal-docs/contributing/releases.md, which still said macOS doesn't sign.Settings already applied
release-signingenvironment with a custom deployment policy of tagv0.1.*. The Windows job already referenced it, but it didn't exist.v0.1.0-rc.1, whose workflow file predates this change, keep working. They'll be deleted once the first tag that includes this change has notarized.MACOS_NOTARIZATION=true. Rerun attempt 11 of run 44903536986 forv0.1.0-rc.1notarized and verifieddarwin_arm64.Testing
cargo test -p nemoclaw-build --test integration -- release_gate macos_signatures release_bundles docs