Repository navigation
fix(release): give each 3S-signed macOS program its own identifier - #14763
Merged
Merged
Conversation
3S signed every program as payload.command, so codesign gave all of them the identifier "payload": macOS treated the CLI, OpenTofu, and every provider as one program for privacy permissions and keychain access. Submit each as com.nvidia.nemoclaw.<program>.command, without a provider's _v<version> suffix, so each keeps a distinct identifier that stays the same across releases, and make the macOS verification require it. Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
Selected hardware E2EsCommit: Selected cases run automatically; results do not gate merging. Shared code or test infrastructure changed.
|
Contributor
|
v1 documentation preview: https://nvidia-preview-nemoclaw-v1-pr-14763.docs.buildwithfern.com/nemoclaw |
cv
enabled auto-merge (squash)
November 22, 2026 00:54
This was referenced Nov 22, 2026
Collaborator
Author
Authoring session — opening
|
cv
disabled auto-merge
November 22, 2026 03:10
cv
enabled auto-merge (squash)
November 22, 2026 03:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives each NVIDIA program in the macOS release bundle its own code-signing identifier,
com.nvidia.nemoclaw.<program>, and makes the release's macOS verification require it.Problem
The 3S signing step submits every program as
payload.command, and the signature's identifier comes from the submitted file's name, so the CLI, OpenTofu, and every provider in thedarwin_arm64bundle carryIdentifier=payload.Notarization and Gatekeeper accept them, but macOS ties privacy permissions and keychain access to the designated requirement, identifier and team, so it treats all of them as one program.
Change
tools/release/macos-signing.rssubmits each program ascom.nvidia.nemoclaw.<program>.command, without a provider's_v<version>suffix, so the identifier stays the same across releases: for examplecom.nvidia.nemoclaw.nemoclaw,com.nvidia.nemoclaw.tofu, andcom.nvidia.nemoclaw.terraform-provider-fabric..github/scripts/verify-macos-signatures.shrequires that identifier for the programs NVIDIA signs; the Helm provider keeps HashiCorp's signature and identifier.internal-docs/contributing/releases.mdnames the identifier.Both signing jobs check out the security controller's revision, so rerunning a candidate from the 3S job re-signs it with these identifiers; rerunning only the macOS job against an older 3S artifact fails verification.
Beyond CI
Against the
v0.1.0-rc.1darwin_arm64bundle, the new verification rejects all eight NVIDIA programs, which carrypayload, and accepts the Helm provider.The new identifiers themselves stay unverified until a release candidate is re-signed through 3S after this merges.