Skip to content

Behavior to add box to the planning scene - #52

Merged
scastro-nasa merged 6 commits into
mainfrom
msavchen/add-object-to-planning-scene
Sep 30, 2026
Merged

scastro-nasa merged 6 commits into
mainfrom
msavchen/add-object-to-planning-scene

Conversation

@msavchen-nasa

Copy link
Copy Markdown
Contributor

No description provided.

@msavchen-nasa
msavchen-nasa requested review from eholum-nasa and scastro-nasa and removed request for scastro-nasa September 29, 2026 22:53

@scastro-nasa scastro-nasa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be easier to just have the behavior accept a PoseStamped and set the header to the CollisionObject message's header? Then you can just couple this with the existing CreatePoseStamped behavior.

Also, unit test?

@msavchen-nasa

Copy link
Copy Markdown
Contributor Author

Would it be easier to just have the behavior accept a PoseStamped and set the header to the CollisionObject message's header? Then you can just couple this with the existing CreatePoseStamped behavior.

I was thinking of keeping things more intuitive and straightforward, and having CreatePose behavior makes imetro_behavior more "complete".
But I also didnt think about mapping PoseStamped's header to CollisionObject's header, sorry about that.

Also, unit test?

I always forget about these.
Give me a couple of minutes.

@scastro-nasa scastro-nasa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll squash the commit so the shared machine doesn't show up as a contributor

@scastro-nasa
scastro-nasa merged commit a6976cd into main Sep 30, 2026
2 checks passed
@scastro-nasa
scastro-nasa deleted the msavchen/add-object-to-planning-scene branch September 30, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants