Fix AdaptiveBeamForceFieldAndMass#237
Open
bakpaul wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
After some investigation, the regression here is indeed a consequence of the PR. Before my PR, because addMDx was broken, when adding the rayleigh damping to the RHS, only the part coming from the rayleigh stiffness was added. Indeed, when adding the part multiplied by M, the forcefield added M*g instead, which is 0 (because here g=0). After trying to recreate the same behavior by removing the rayleigh stiffness from the RHS, the results are closer than the expected precision. So I'll regenerate the references to fix this regression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This component was broken wince the begining but it wasn't an issue until I needed to accumulate inertia terms on the RHS of the Integration scheme. The problem here is thazt the addMDx method ignores the dx passed and always uses the same value. This broke completely the dynamics, nullifying the contribution of the mass to the RHS.
It was identified by AI, and the code was made by AI, but it works properly now thank's to this.