Skip to content

Dispose the upload stream in the integration fixture #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hahn-kev merged 1 commit into from
Oct 28, 2026
Merged

Dispose the upload stream in the integration fixture #2844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion backend/Testing/Fixtures/IntegrationFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,10 @@ public async Task FinishLexboxProjectResetWithTemplateRepo(string projectCode)
public async Task FinishLexboxProjectResetWithRepo(string projectCode, FileInfo repo)
{
Exception? failureException = null;
// UploadFile.FromFile opens a FileStream nobody disposes; Windows then refuses to delete the zip.
await using var stream = repo.OpenRead();
await AdminApiTester.HttpClient.UploadWithProgressAsync(new Uri($"{AdminApiTester.BaseUrl}/api/project/upload-zip/{projectCode}"),
UploadFile.FromFile(repo, "application/zip"), new UploadOptions
new UploadFile(stream, repo.Name, "application/zip", repo.Length), new UploadOptions
{
Metadata = new Dictionary<string, string> { ["filetype"] = "application/zip" },
ProgressHandler = new DelegatingProgressHandler
Expand Down
Loading