Repository navigation
Dispose the upload stream in the integration fixture - #2844
Merged
Merged
Conversation
UploadFile.FromFile opens a FileStream that neither the TusClient nor UploadFile ever disposes. On Windows the deferred delete of the temp zip then fails with "being used by another process", which broke three ProjectRepoTests in the release pipeline's Windows integration jobs. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
📦 Lexbox
hahn-kev
approved these changes
Oct 28, 2026
hahn-kev
added
the
self-reviewed 👁️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI summary
IntegrationFixture.FinishLexboxProjectResetWithRepousedUploadFile.FromFile, which opens aFileStreamthat neitherUploadFilenor the Squidex TusClient ever disposes. On Linux that goes unnoticed, but on Windows the deferred delete of the temp zip fails with "being used by another process".This broke three
ProjectRepoTests(BackupProject_ZipRestoresTheSameRepo,BackupProject_OfEmptyRepo_RestoresAnEmptyRepo,ResetProject_UploadZipWithNestedHgAndWorkingFiles_UsesTheNestedRepo) in both Windows integration jobs of the release pipeline run. The tests landed in #2751 and today was their first run on Windows, since only the release pipeline runs integration tests there.The fixture now opens the stream itself with
await usingand passes it to theUploadFileconstructor.Test plan
backend/Testingbuilds.🤖 Generated with Claude Code