Skip to content

Task - Add the courses.view_advanced_settings permission #328

Closed
3 of 3 issues completed
Closed

Description

@MaferMazu

Description

We want to modify https://github.com/openedx/openedx-platform/blob/ff0690f6c8768158dd07ab6a43e88e8695798283/common/djangoapps/student/auth.py#L183 to allow read access by default when using the new authz system (we don't need an explicit view permission for read).

In #283, we have that if someone doesn't have the manage_advanced_setting permission, they can see advanced_settings but can't edit them (read-only).

Right now, in the code, we are also restricting the view (if they don't have manage, they can't view); we want to fix that.

Acceptance criteria

PR merged that allows reading the advanced settings, and the manage_advanced_settings permission is only used to write actions.

Related PRs

Activity

  1. changed the title [-]Fix the manage advanced setting enforcer in edx-platform[/-] [+]Task - Change the manage advanced setting enforcer in edx-platform[/+] on Jun 5, 2026
  2. MaferMazu commented on Aug 4, 2026

    @MaferMazu
    ContributorAuthor

    I created this task because in the permissions defined in openedx-authz, we only had manage_advanced_setting. So we expect that, by default, if we are using openedx-authz, we can read the advanced settings. - In the code, currently we are expecting a specific read. <- If we want to maintain only the manage_advanced_setting, we should in some way allow the read by default if we are using openedx-authz.

    Designs by permission: #283 (comment)
    Edx-platform enforcement point: https://github.com/openedx/openedx-platform/blob/ff0690f6c8768158dd07ab6a43e88e8695798283/common/djangoapps/student/auth.py#L183

    cc @BryanttV

  3. MaferMazu commented on Aug 4, 2026

    @MaferMazu
    ContributorAuthor

    But after reading again: https://docs.openedx.org/projects/openedx-authz/en/latest/concepts/core_roles_and_permissions/course_roles.html#advanced-certificates, maybe we should hide it if someone doesn't have manage_advanced_setting; if so, we can discard this issue.

    cc @gviedma-aulasneo @BryanttV

  4. BryanttV commented on Aug 4, 2026

    @BryanttV
    Contributor

    This was validated with @gviedma-aulasneo, and it was decided to create a new permission (courses.view_advanced_settings).

    This requires changes in:

    • openedx-authz: Create the new permission, add it to the corresponding roles, and update the documentation.
    • openedx-platform: Enforce the new permission on the applicable endpoints.
    • frontend-app-admin-console: Add the new permission to the roles and permissions matrix.
  5. moved this to Ready for Development in RBAC AuthZ Boardon Aug 4, 2026
  6. 6 remaining items

  7. moved this from In Progress to Done in RBAC AuthZ Boardon Aug 18, 2026
  8. moved this from Done to In Progress in RBAC AuthZ Boardon Aug 18, 2026
  9. BryanttV commented on Aug 18, 2026

    @BryanttV
    Contributor

    openedx-authz PR merged!

    Pending changes in openedx-platform and frontend-app-admin-console

  10. changed the title [-]Task - Change the manage advanced setting enforcer in edx-platform[/-] [+]Task - Add the `courses.view_advanced_settings` permission[/+] on Aug 18, 2026
  11. added a commit that references this issue on Aug 20, 2026
    e68de69
  12. moved this from In Progress to No status in RBAC AuthZ Boardon Aug 20, 2026
  13. closed this as completedby moving to Done in RBAC AuthZ Boardon Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions