Skip to content

styles: use fixed widths for user roles table in large screens and allow wrap text in page header - #254

Open
dcoa wants to merge 5 commits into
openedx:masterfrom
eduNEXT:dcoa/fix-team-members-table-widths
Open

dcoa wants to merge 5 commits into
openedx:masterfrom
eduNEXT:dcoa/fix-team-members-table-widths

Conversation

@dcoa

@dcoa dcoa commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

The columns has a fix width based on the Figma design and the values where implemented in #222 but there were not applied as you can see here #222 (review). The PR enable the table static width from medium screens, in small screens it keep the default auto-resizing behavior for paragon.

Screencast.from.2026-10-09.09-40-34.webm

It also works in a edge case in the header where a title and subtitle are long they don't wrap instead overflow the page.

Before
Screenshot from 2026-10-08 18-18-47

After

image

The column widths, fixed layout and row padding were nested under
`&.team-members-table`, which compiles to `.authz-module.team-members-table`.
No element carried that class, so none of it applied and the columns
resized to each page's content. Match the class as a descendant of
`.authz-module` and set it on the team members DataTable.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Oct 8, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @dcoa!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

dcoa and others added 2 commits October 9, 2026 09:29
…actions

A username or email without spaces could not wrap, so on the audit user page
a long email overflowed its column and slid under the Assign Role button.
Let the title and subtitle break inside their column.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dcoa
dcoa force-pushed the dcoa/fix-team-members-table-widths branch from bea4b4d to 389f717 Compare October 8, 2026 22:29
@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.71%. Comparing base (fccbc43) to head (d064e21).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          80       80           
  Lines        1396     1396           
  Branches      438      438           
=======================================
  Hits         1378     1378           
  Misses         18       18           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcoa

dcoa commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

@jacobo-dominguez-wgu I was thinking the table might have a minimum width so the relevant information is properly displayed in small screens, This is out of the scope as a proposal but wanted to discuss. For example, for the team members a min-width of 768x.

This is how the table scrolls today

Screencast.from.2026-10-09.10-16-28.webm

This is how it looks with the minimum width

Screencast.from.2026-10-09.10-20-05.webm

@dcoa dcoa changed the title styles: use fixed widths for table in large screens and allow wrap text in page header styles: use fixed widths for user roles table in large screens and allow wrap text in page header Oct 9, 2026
@jacobo-dominguez-wgu

Copy link
Copy Markdown
Contributor

@jacobo-dominguez-wgu I was thinking the table might have a minimum width so the relevant information is properly displayed in small screens, This is out of the scope as a proposal but wanted to discuss. For example, for the team members a min-width of 768x.

This is how the table scrolls today

Screencast.from.2026-10-09.10-16-28.webm
This is how it looks with the minimum width

Screencast.from.2026-10-09.10-20-05.webm

I agree, looks better with it.

@jacobo-dominguez-wgu jacobo-dominguez-wgu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

3 participants