Repository navigation
feat(authz): refine team members tab layout and sizes - #251
Conversation
openedx-webhooks
added
open-source-contribution
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
=======================================
Coverage 98.71% 98.71%
=======================================
Files 80 80
Lines 1396 1400 +4
Branches 438 470 +32
=======================================
+ Hits 1378 1382 +4
Misses 18 18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The action icon (eye) in the figma looks centered and here it is align to left |
8addbaf to
a780fe4
Compare
a780fe4 to
d258b8f
Compare
This was not originally part of the scope of the ticket but I will check if I can include it. |
There was a problem hiding this comment.
LGTM. @jacobo-dominguez-wgu don't worry about the action alignment, I will open a PR about the table styles and include it.
Managed here #254
| }; | ||
|
|
||
| // "md" is mapped to undefined because Paragon's Form.Control has no "md" size. | ||
| export const validateSizeFormControl = (size) => |
There was a problem hiding this comment.
I approved because it matches the Figma, but I don't understand what is the value of this utility?
If the idea is display all the search in small size, why just not apply sm directly to the control component?
There was a problem hiding this comment.
The idea is to keep the component flexible/reusable so in case a different size is needed we have an easy way to implement it.
jesusbalderramawgu
left a comment
jesusbalderramawgu
left a comment
There was a problem hiding this comment.
Thank you for addressing my comments, looks good to me!
|
🎉 This PR is included in version 1.0.0-alpha.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 participants
Description
Refining authz team members tab by modifying current controls sizes for the table filter elements, the horizontal padding between the container and the table was removed and the overall page spacing was adjusted, also removed custom background color.
Closes #241
Figma design
Testing
sizebehavior on both filters, including the'md' → undefinedmapping, asserting on the rendered Paragon size classes.Screenshots