Repository navigation
feat(authz): refine audit user page layout and spacing - #252
jacobo-dominguez-wgu wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #252 +/- ##
=======================================
Coverage 98.71% 98.71%
=======================================
Files 80 80
Lines 1400 1401 +1
Branches 470 472 +2
=======================================
+ Hits 1382 1383 +1
Misses 18 18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
e270bd3 to
cf6384f
Compare
jesusbalderramawgu
left a comment
There was a problem hiding this comment.
pulled the code locally, looks good. Thank you
cf6384f to
5634c04
Compare
Description
Polishing the audit user page. Added an optional
borderBottomprop toAuthZTitlethat renders a bottom border under the title band, enabled it on the audit user page, and tightened the page spacing (py-5→py-3). The border is defined with Paragon tokens so it stays theme-aware. The table filter components are smaller but not by a direct modification of this pr but inherited from #251Closes #242
Figma design
Testing
AuthZTitleborderBottomprop, asserting thetitle-border-bottomclass is present only when the prop is passed.AuthZTitlesuite still passes (10 tests).Screenshots