Skip to content

feat(authz): refine audit user page layout and spacing - #252

Open
jacobo-dominguez-wgu wants to merge 1 commit into
masterfrom
jacobo/audit-user-polish
Open

jacobo-dominguez-wgu wants to merge 1 commit into
masterfrom
jacobo/audit-user-polish

Conversation

@jacobo-dominguez-wgu

@jacobo-dominguez-wgu jacobo-dominguez-wgu commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

Polishing the audit user page. Added an optional borderBottom prop to AuthZTitle that renders a bottom border under the title band, enabled it on the audit user page, and tightened the page spacing (py-5 → py-3). The border is defined with Paragon tokens so it stays theme-aware. The table filter components are smaller but not by a direct modification of this pr but inherited from #251

Closes #242
Figma design

Testing

  • Added unit tests for the AuthZTitle borderBottom prop, asserting the title-border-bottom class is present only when the prop is passed.
  • Existing AuthZTitle suite still passes (10 tests).
  • Go to the specific user (audit user) page and verify the title has a bottom border and the spacing matches the figma design.

Screenshots

Before After
image image

@jacobo-dominguez-wgu
jacobo-dominguez-wgu added this pull request to stack #253 October 8, 2026 21:24
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Oct 8, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @jacobo-dominguez-wgu!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.71%. Comparing base (8c8829a) to head (5634c04).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          80       80           
  Lines        1400     1401    +1     
  Branches      470      472    +2     
=======================================
+ Hits         1382     1383    +1     
  Misses         18       18           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcoa dcoa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some nits

Comment thread src/authz-module/components/AuthZTitle.tsx Outdated
Comment thread src/authz-module/index.scss Outdated
Comment thread src/authz-module/audit-user/index.tsx
@jacobo-dominguez-wgu
jacobo-dominguez-wgu force-pushed the jacobo/audit-user-polish branch 2 times, most recently from e270bd3 to cf6384f Compare October 9, 2026 15:19

@jesusbalderramawgu jesusbalderramawgu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pulled the code locally, looks good. Thank you

Base automatically changed from jacobo/team-memebers-polish to master October 9, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

Audit User page: title spacing/border, button size, white background, table padding, filter buttons

4 participants