Repository navigation
Bump the version to 2.0.0 - #51
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
As long as we're moving to version 2, should we drop the legacy support? AFAIK no one is using it, and it doesn't support user authentication (which everyone wants), and it's been deprecated since 1.0. |
Collaborator
Author
Ok. I will stack a removal PR on top of this one, so its semver remains green. |
brotskydotcom
approved these changes
Nov 3, 2026
LucaCappelletti94
force-pushed
the
version-2.0.0
branch
from
November 8, 2026 20:55
375300e to
102d9e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 1.0.0,
StoreConfiggained the publicuser_auth_timeoutfield and#[non_exhaustive]with the user authentication support from #28. Code that builds aStoreConfigwith a struct literal no longer compiles, so the next release has to be 2.0.0, andcargo-semverfails on main and on every pull request until the version says so.This only changes the version and publishes nothing until a
v2.0.0tag is pushed.keyringdepends on^1and only usesStore, so it needs a dependency bump to pick up 2.0.0.Now, bumping all the way to version 2 because of this seems excessive to me, but them's the semver rules.