Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/argparse.js
Original file line number Diff line number Diff line change
Expand Up @@ -1903,7 +1903,7 @@ const _ExtendAction = _callable(class _ExtendAction extends _AppendAction {
call (parser, namespace, values/*, option_string = undefined */) {
let items = getattr(namespace, this.dest, undefined)
items = _copy_items(items)
items = items.concat(values)
items = items.concat(typeof values === 'string' ? Array.from(values) : values)
setattr(namespace, this.dest, items)
}
})
Expand Down
13 changes: 13 additions & 0 deletions test/test_argparse.js
Original file line number Diff line number Diff line change
Expand Up @@ -2468,6 +2468,19 @@ class WFile {
]
}).run()

;(new class TestActionExtendDefaultNargs extends ParserTestCase {
/* Without nargs, a single value is a string, and extend() spreads it
* character by character, same as Python's list.extend() on a str */

argument_signatures = [
Sig('--foo', { action: 'extend' }),
]
failures = []
successes = [
['--foo abc', NS({ foo: ['a', 'b', 'c'] })],
]
}).run()

;(new class TestNegativeNumber extends ParserTestCase {
/* Test parsing negative numbers */

Expand Down