fix: extend action should spread a scalar string by code point - #190
Open
spokodev wants to merge 1 commit into
Open
fix: extend action should spread a scalar string by code point#190spokodev wants to merge 1 commit into
spokodev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
action: 'extend'withoutnargsreceives a single string value. Python'sextendrunslist.extend(values), andlist.extendon astriterates it by code point, so--foo abcproduces['a', 'b', 'c']. This port concatenates the string as a single element instead, producing['abc']— a silent divergence from the CPython 3.14.6 behaviour it targets (and not one of the intentional differences indoc/port_difference.md).Spreading with
Array.fromwhen the value is a string matches Python's per-code-point iteration, including astral characters:--foo a😀b→['a', '😀', 'b'], exactly as CPython 3.14.6 produces.