Repository navigation
fix(mit-ol): pin openedx-forum 0.4.7 in place of the fork branch - #229
Merged
Merged
Conversation
openedx/forum#289 released in 0.4.7 (0.4.6 never reached PyPI). The git override was a direct reference to a branch that is now dead, and nothing would have flagged it going stale. edx-platform still pins 0.4.3 on master and 0.4.2 on release/verawood, so the override stays, as a version pin. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J43t1WXNsmVV5mbdzxv6iT
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The published package and compatibility constraints were verified, and the manifest changes are consistent across all intended cells.
Pull request overview
Replaces the temporary forum fork with the released openedx-forum==0.4.7 package.
Changes:
- Pins 0.4.7 across six Python 3.12 cells.
- Preserves the 0.4.1 pin for the Python 3.11 Ulmo cell.
- Updates removal guidance for the override.
File summaries
| File | Description |
|---|---|
deployments/mit-ol/build_manifest.yaml |
Updates forum overrides for master and Verawood cells. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openedx/forum#289 merged and released, so the six cells that installed forum from
mitodl/forum@tmacey/fix-typesense-search-params(added in #208) now pinopenedx-forum==0.4.7.It stays an override rather than being removed: edx-platform pins
0.4.3on master and0.4.2on release/verawood, and neither has the fix. The comment says to drop it once the branch pin reaches 0.4.7.0.4.7 is the first release carrying the fix that exists on PyPI. 0.4.4 through 0.4.6 were tagged on GitHub but never published; 0.4.7 differs from 0.4.6 only in
.github/workflows/release.yml.Against the fork branch, 0.4.7 changes code in one commit: openedx/forum#239 ("do not update LMS user during retirement",
api/users.pyandbackends/mysql/api.py).src/forum/searchis identical.ulmo × xpro is untouched and stays on
openedx-forum==0.4.1(forum requires Python >=3.12; that cell builds on 3.11).🤖 Generated with Claude Code
https://claude.ai/code/session_01J43t1WXNsmVV5mbdzxv6iT