Repository navigation
fix: drop CodeOwnerMonitoringMiddleware from the master LMS settings models - #231
Merged
Merged
Conversation
…ware removal edx-platform master dropped CodeOwnerMonitoringMiddleware from MIDDLEWARE, so the committed model no longer matches a fresh render and settings-verify fails for every master cell, including main's scheduled run. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J43t1WXNsmVV5mbdzxv6iT
…settings model Same upstream removal as the mit-ol model. main's scheduled settings-verify reported the identical one-line drift for generic/master/generic. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J43t1WXNsmVV5mbdzxv6iT
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both reviewed files align with the upstream middleware configuration.
Pull request overview
Updates master LMS Aqueduct settings models to match upstream by removing obsolete middleware.
Changes:
- Removed
CodeOwnerMonitoringMiddlewarefrom both LMS models. - Left CMS models unchanged.
File summaries
| File | Summary |
|---|---|
deployments/mit-ol/settings/lms/models/aqueduct.py |
Removed stale middleware entry. |
deployments/generic/settings/lms/models/aqueduct.py |
Removed stale middleware entry. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openedx/openedx-platform#39047 (319c1964e3, merged 2026-09-10) removed
edx_django_utils.monitoring.CodeOwnerMonitoringMiddlewarefromMIDDLEWAREinlms/envs/common.py. Both committed master LMS models still list it, sosettings-verifyreports drift on every master cell: main's scheduled run at 2026-09-14T07:27Z failed on mit-ol mitxonline, mitx, mitx-staging and generic, and the same drift fails the three settings checks on #229.deployments/mit-ol/settings/lms/models/aqueduct.py: regenerated withdagger call platform regenerate-aqueduct-settings --deployment-name mitxonline --release-name master --build-manifest deployments/mit-ol/build_manifest.yaml. The one-line removal is the only change; the CMS model rendered identical to what is committed.deployments/generic/settings/lms/models/aqueduct.py: the same line removed by hand, matching the diff main's run printed forgeneric/master/generic(one hunk, LMS only).🤖 Generated with Claude Code
https://claude.ai/code/session_01J43t1WXNsmVV5mbdzxv6iT