Repository navigation
Queue Maven team memory through Java Pack coordinator - #1224
Merged
Merged
Conversation
Replace direct maintenance with a scoped dispatch-only caller and document caller and central source-read rollout prerequisites. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Changyong Gong (chagong)
requested review from
Sheng Chen (jdneo),
Jinbo Wang (testforstephen) and
wenyt (wenytang-ms)
as code owners
October 10, 2026 06:42
Restore the pre-migration team-memory policy exactly at user request, leaving the workflow migration unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
wenyt (wenytang-ms)
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace Maven's direct IssueLens team-memory invocation with a minimal dispatch-only caller for the merged Java Pack coordinator. Only
.github/workflows/team-memory-post-merge.ymlchanges. Per user request, all documentation edits introduced by this migration have been removed, restoring the existing runtime/wiki policy exactly to its pre-migration content. Issue triage and extension behavior/workflows remain untouched.ISSUELENS_TEAM_MEMORY_ENABLED == 'true'opt-in and fixed source workflow path. Admit only actualmicrosoft/vscode-mavendefault-branch pushes with matching workflow/head SHAs andcreated,deleted, andforcedall false.actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1(v3.2.0), restricted tomicrosoft/vscode-java-packwith Contents read and Actions write. The caller'sGITHUB_TOKENreceives no permissions.microsoft/IssueLens/.github/actions/queue-team-memory@a81d2d96167fc0e69ac631c2edc85f858e693289, explicitly targetingmicrosoft/vscode-java-pack,team-memory-coordinator.yml, andmain, independently of the source ref. Send exactly five string inputs:source_repository,source_run_id,source_run_attempt,push_before, andpush_after.The standalone action validates target metadata and attempts one bounded POST with no automatic retry. Acceptance confirms dispatch only, not queue admission or completed maintenance. The requested
push_beforeauthorizes ancestor reconciliation; it is not attested original-event provenance.Rollout prerequisites — configure before merging with the source opt-in enabled
Keep these internal setup prerequisites in this PR description, not repository documentation. Read-only Maven configuration-name inspection during PR preparation found the existing
ISSUELENS_TEAM_MEMORY_ENABLEDvariable, but neither new caller credential name:ISSUELENS_DISPATCH_APP_CLIENT_IDand secretISSUELENS_DISPATCH_APP_PRIVATE_KEY, for a dedicated dispatch App installed only on Java Pack with Contents read + Actions write. These are proposed caller setup names, not upstream-required names. Do not reuse the hosted IssueLens App key or central source-read credentials.ISSUELENS_SOURCE_READ_APP_CLIENT_IDandISSUELENS_SOURCE_READ_APP_PRIVATE_KEY, for the separate source-read App installed on selected source repositories including Maven with Actions/Contents/Pull requests read. The coordinating investigation at preparation time confirmed both were missing, with no inherited organization secrets. Maven is already in the central source allowlist.A successful Java Pack own-repository run skips external authentication and does not establish external-source readiness. Merging while the source opt-in is already
trueswitches eligible pushes to queue-only dispatch; missing credentials fail without falling back to direct invocation. No live variables, secrets, credentials, or permissions were changed. The token could not read the repository Actions-policy endpoints (HTTP 403), so allowlisted-action policy compatibility was not inspected.Validation
actionlintv1.7.12 passed for the changed source workflow (official release archive checksum verified).mainindependence; exact five-string payload; both pinned action input schemas; explicit repository/permission scope; no direct invocation, checkout, artifacts, retry, or triage/extension changes.configuration()validation with a placeholder token and network access blocked. No dispatch, workflow rerun, App token minting, Azure login, or hosted invocation was used as a test..github/issuelens/team-memory.mdexactly matches its pre-migration content. The workflow is byte-for-byte unchanged from the previously validated migration commit; fresh offline YAML assertions confirm preserved source gates, scoped permissions, target/ref, and five-string payload.git diff --checkpassed. Self-review confirms the complete PR diff contains only.github/workflows/team-memory-post-merge.yml; the normal follow-up commit changes documentation only. No builds/unit suites were run because extension code and dependencies are unchanged.Prepared from freshly fetched
mainateee9eb0b49b8b5bdd4a479646d700340a2b37cbd.Current head:
da6f6858c22d6e82ab6ebe78feb95ee4215ceabf(normal follow-up; no amend or force push).