Skip to content

ci: use built-in token for team-memory dispatch - #1225

Closed
Changyong Gong (chagong) wants to merge 1 commit into
mainfrom
chagong-maven-built-in-dispatch-token
Closed

Changyong Gong (chagong) wants to merge 1 commit into
mainfrom
chagong-maven-built-in-dispatch-token

Conversation

@chagong

Copy link
Copy Markdown
Contributor

Known cross-repository authorization blocker — DRAFT / NOT MERGE-READY: ${{ github.token }} is scoped to microsoft/vscode-maven and does not have Actions-write access to microsoft/vscode-java-pack. Job-level actions: write does not expand the token's repository scope. This user-directed substitution is not a working, proven cross-repository dispatch replacement and must not be merged as-is. Java Pack's own-source workflow uses a same-repository token; that reference, a public read diagnostic, and passing CI do not establish caller write authorization.

Requested change

  • Remove the actions/create-github-app-token dispatch-token mint step and its App credential references.
  • Set dispatch-job permissions to contents: read / actions: write, preserving top-level permissions: {}.
  • Pass ${{ github.token }} to the queue action, following the wiring in Java Pack's main .github/workflows/team-memory-post-merge.yml.

Preserved scope and behavior

Only .github/workflows/team-memory-post-merge.yml changes, based on current default main (d83e339b4a1cbeb7ba3f39fbabce179786909a23), not the former #1224 feature branch. All eight opt-in/canonical-source/default-push/workflow-head/non-created/non-deleted/non-forced gates remain unchanged. The immutable IssueLens action pin, explicit Java Pack coordinator repository/workflow/main target, and exact five string-valued JSON inputs remain unchanged. No documentation, credentials, opt-in settings, architecture, fallback, or unrelated workflows are changed. Production remains unchanged; no merge or auto-merge is requested.

Validation

Offline PyYAML parsing with duplicate-key rejection and structural assertions passed. Comparison against the fetched main workflow confirms exactly the requested semantic changes; checks verify the preserved gates, action pin, coordinator target, JSON payload, permissions, removal of dangling token-output/credential references, and workflow-only file scope. git diff --check passed. No live token mint, coordinator POST/dispatch, or rerun was performed; these checks do not verify cross-repository dispatch authorization.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants