Repository navigation
ci: use built-in token for team-memory dispatch - #1225
Closed
Changyong Gong (chagong) wants to merge 1 commit into
Closed
Changyong Gong (chagong) wants to merge 1 commit into
Changyong Gong (chagong) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Changyong Gong (chagong)
marked this pull request as ready for review
October 12, 2026 02:49
Changyong Gong (chagong)
requested review from
Sheng Chen (jdneo),
Jinbo Wang (testforstephen) and
wenyt (wenytang-ms)
as code owners
October 12, 2026 02:49
wenyt (wenytang-ms)
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Known cross-repository authorization blocker — DRAFT / NOT MERGE-READY:
${{ github.token }}is scoped tomicrosoft/vscode-mavenand does not have Actions-write access tomicrosoft/vscode-java-pack. Job-levelactions: writedoes not expand the token's repository scope. This user-directed substitution is not a working, proven cross-repository dispatch replacement and must not be merged as-is. Java Pack's own-source workflow uses a same-repository token; that reference, a public read diagnostic, and passing CI do not establish caller write authorization.Requested change
actions/create-github-app-tokendispatch-token mint step and its App credential references.contents: read/actions: write, preserving top-levelpermissions: {}.${{ github.token }}to the queue action, following the wiring in Java Pack's main.github/workflows/team-memory-post-merge.yml.Preserved scope and behavior
Only
.github/workflows/team-memory-post-merge.ymlchanges, based on current defaultmain(d83e339b4a1cbeb7ba3f39fbabce179786909a23), not the former #1224 feature branch. All eight opt-in/canonical-source/default-push/workflow-head/non-created/non-deleted/non-forced gates remain unchanged. The immutable IssueLens action pin, explicit Java Pack coordinator repository/workflow/maintarget, and exact five string-valued JSON inputs remain unchanged. No documentation, credentials, opt-in settings, architecture, fallback, or unrelated workflows are changed. Production remains unchanged; no merge or auto-merge is requested.Validation
Offline PyYAML parsing with duplicate-key rejection and structural assertions passed. Comparison against the fetched
mainworkflow confirms exactly the requested semantic changes; checks verify the preserved gates, action pin, coordinator target, JSON payload, permissions, removal of dangling token-output/credential references, and workflow-only file scope.git diff --checkpassed. No live token mint, coordinator POST/dispatch, or rerun was performed; these checks do not verify cross-repository dispatch authorization.