1.8: soft_apic: Add some diagnostics (#4079) - #4126
Merged
Steven Malis (smalis-msft) merged 1 commit intoAug 4, 2026
Merged
Conversation
We've had a few test flakes of openvmm_openhcl_uefi_x64_windows_datacenter_core_2022_x64_uefi_force_dma_bounce recently. Copilot says these diagnostics are necessary to be able to determine the root cause of the problem. (cherry picked from commit 322aed5)
Steven Malis (smalis-msft)
added
the
release_1.8.2607
Contributor
There was a problem hiding this comment.
Pull request overview
This backport adds additional diagnostics for MSI/MSI-X delivery paths to help investigate intermittent test flakes by making dropped/latched interrupt state more observable.
Changes:
- Emit a rate-limited warning when the software APIC receives an MSI for an unregistered interrupt index (instead of silently dropping it).
- Improve MSI-X inspect output by showing
MsiInterruptInneraddress/data in hex and exposing the delivery-state (msi) alongside the table entry state.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vmm_core/virt/src/x86/apic_software_device.rs | Logs a ratelimited warning when an MSI maps to no registered interrupt entry. |
| vm/devices/pci/pci_core/src/capabilities/msix.rs | Enhances inspect diagnostics for MSI-X by hex-formatting address/data and including delivery state in inspection output. |
Steven Malis (smalis-msft)
enabled auto-merge (squash)
July 31, 2026 17:20
Matt LaFayette (Kurjanowicz) (mattkur)
approved these changes
Aug 4, 2026
Steven Malis (smalis-msft)
merged commit Aug 4, 2026
da21e50
into
microsoft:release/1.8.2607
154 of 158 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4079 to
release/1.8.2607.The cherry-pick of 322aed5 applied cleanly onto
release/1.8.2607with no conflicts and no manual edits.Original PR: #4079
This backport PR was created by an AI agent (GitHub Copilot) on behalf of Steven Malis (@smalis-msft).