soft_apic: Add some diagnostics - #4079
Merged
Steven Malis (smalis-msft) merged 2 commits intoJul 29, 2026
Merged
Conversation
Steven Malis (smalis-msft)
added
the
backport_1.8.2607
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds additional diagnostics around MSI/MSI-X interrupt delivery to help triage recent flakes (notably openvmm_openhcl_uefi_x64_windows_datacenter_core_2022_x64_uefi_force_dma_bounce) by making “unexpected / dropped interrupt” situations visible and improving MSI-X introspection.
Changes:
- Emit a ratelimited warning when an MSI is signaled for an unregistered interrupt in the x86 software APIC device.
- Improve MSI-X inspect output by showing MSI delivery state alongside the message table, and rendering address/data in hex in the delivery state.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vmm_core/virt/src/x86/apic_software_device.rs | Adds a ratelimited warning when an MSI is signaled for an interrupt index not present in the software interrupt table. |
| vm/devices/pci/pci_core/src/capabilities/msix.rs | Enhances inspectability of MSI-X vectors by adding hex formatting for address/data in delivery state and exposing the msi delivery state in table entry inspection. |
Steven Malis (smalis-msft)
enabled auto-merge (squash)
July 29, 2026 16:47
John Starks (jstarks)
approved these changes
Jul 29, 2026
Steven Malis (smalis-msft)
merged commit Jul 29, 2026
322aed5
into
microsoft:main
98 of 101 checks passed
Steven Malis (smalis-msft)
removed
the
backport_1.8.2607
Steven Malis (smalis-msft)
added a commit
that referenced
this pull request
Aug 4, 2026
Backport of #4079 to `release/1.8.2607`. The cherry-pick of 322aed5 applied cleanly onto `release/1.8.2607` with no conflicts and no manual edits. Original PR: #4079 --- *This backport PR was created by an AI agent (GitHub Copilot) on behalf of @smalis-msft.*
Member
|
Backported to release/1.8.2607 in #4126 |
Ben Hillis (benhillis)
added
the
backported_1.8.2607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had a few test flakes of openvmm_openhcl_uefi_x64_windows_datacenter_core_2022_x64_uefi_force_dma_bounce recently. Copilot says these diagnostics are necessary to be able to determine the root cause of the problem.