Repository navigation
Update runtime dependencies for Java Language Server - #126
Closed
Tim Vergenz (vergenzt) wants to merge 3 commits into
Closed
Tim Vergenz (vergenzt) wants to merge 3 commits into
Tim Vergenz (vergenzt) wants to merge 3 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
Collaborator
|
This looks good! One issue: the JRE paths are upgraded to Java 21, but I'll push a follow-up commit after merging to fix this. Credit to Stephen Rayner (@gruckion) who caught this in #128. |
Lakshya A Agrawal (LakshyAAAgrawal)
pushed a commit
to LakshyAAAgrawal/multilspy-cicd-fix
that referenced
this pull request
Apr 10, 2026
The JRE bundled with vscode-java was upgraded from Java 17 to Java 21 in microsoft#126, but the JavaSE runtime name references in eclipse_jdtls.py and initialize_params.json were not updated. This causes an assertion failure at runtime because the assert expects JavaSE-17 in the config but the JSON now specifies Java 21 paths. Caught by @gruckion in microsoft#128.
Lakshya A Agrawal (LakshyAAAgrawal)
pushed a commit
to LakshyAAAgrawal/multilspy-cicd-fix
that referenced
this pull request
Apr 10, 2026
Upgrade Eclipse JDTLS runtime dependencies: - vscode-java: v1.23.0 -> v1.46.0 - Bundled JRE: Java 17 -> Java 21 (JavaSE-17 -> JavaSE-21) - Gradle: 7.3.3 -> 7.6.6 (with templated URL) - Lombok: 1.18.30 -> 1.18.39 - IntelliCode: 1.2.30 -> 1.3.2 - Equinox launcher: 1.6.500 -> 1.7.0 - Fix osx-arm64: was incorrectly downloading x64 binary Based on work by @vergenzt (microsoft#126) and @gruckion (microsoft#128). Closes microsoft#126, closes microsoft#128. Contributed-by: Tim Vergenz <vergenzt@users.noreply.github.com> Contributed-by: Stephen Rayner <contact@gruckion.com>
Collaborator
|
Thank you Tim Vergenz (@vergenzt)! Your changes are incorporated into #139 which resolves the merge conflicts with current main. You're credited as a contributor in the commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.