Repository navigation
Update JavaSE-17 references to JavaSE-21 for JDTLS JRE upgrade - #138
Closed
Lakshya A Agrawal (LakshyAAAgrawal) wants to merge 1 commit into
Closed
Lakshya A Agrawal (LakshyAAAgrawal) wants to merge 1 commit into
Lakshya A Agrawal (LakshyAAAgrawal) wants to merge 1 commit into
Conversation
The JRE bundled with vscode-java was upgraded from Java 17 to Java 21 in microsoft#126, but the JavaSE runtime name references in eclipse_jdtls.py and initialize_params.json were not updated. This causes an assertion failure at runtime because the assert expects JavaSE-17 in the config but the JSON now specifies Java 21 paths. Caught by @gruckion in microsoft#128.
Collaborator
Author
|
Superseded by #139 which includes the full JDTLS upgrade with the JavaSE-21 fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The JRE bundled with vscode-java was upgraded from Java 17 to Java 21 in #126, but the
JavaSEruntime name references were not updated. Without this fix, JDTLS initialization fails with an assertion error because the assert expectsJavaSE-17in the config but the JSON now specifies Java 21 paths.Changes
eclipse_jdtls.py:JavaSE-17→JavaSE-21in runtime config assert and assignment (2 lines)initialize_params.json:JavaSE-17→JavaSE-21(1 line)Attribution
This issue was caught by Stephen Rayner (@gruckion) in #128. The commit is authored by them.
Merge after #126.