Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion boltons/timeutils.py
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ def decimal_relative_time(d, other=None, ndigits=0, cardinalize=True):

"""
if other is None:
if d.tzinfo is None:
if d.utcoffset() is None:
other = datetime.now(timezone.utc).replace(tzinfo=None)
else:
other = datetime.now(d.tzinfo)
Expand Down
23 changes: 22 additions & 1 deletion tests/test_timeutils.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,28 @@
import pytest

from boltons.timeutils import (daterange, isoparse, Eastern, dt_to_timestamp,
parse_timedelta)
parse_timedelta, decimal_relative_time, relative_time)


@pytest.mark.parametrize('future', [False, True])
@pytest.mark.parametrize('as_text', [False, True])
def test_relative_time_naive_timezone_defaults_to_now(future, as_text):
class NaiveTimezone(tzinfo):
def utcoffset(self, dt):
return None

offset = timedelta(days=2 if future else -2)
value = (datetime.now(timezone.utc) + offset).replace(tzinfo=NaiveTimezone())
if as_text:
assert relative_time(value) == ('2 days from now' if future else '2 days ago')
else:
assert decimal_relative_time(value) == (-2.0 if future else 2.0, 'days')


@pytest.mark.parametrize('tz', [None, timezone(timedelta(hours=2))])
def test_relative_time_defaults_preserve_standard_timezones(tz):
value = datetime.now(tz) - timedelta(days=2)
assert decimal_relative_time(value) == (2.0, 'days')


def test_daterange_years():
Expand Down