Skip to content

Handle naive custom timezones in relative time defaults - #656

Open
ShahadatTest wants to merge 1 commit into
mahmoud:masterfrom
ShahadatTest:fix/relative-time-naive-timezones
Open

ShahadatTest wants to merge 1 commit into
mahmoud:masterfrom
ShahadatTest:fix/relative-time-naive-timezones

Conversation

@ShahadatTest

Copy link
Copy Markdown

The change

Determine datetime awareness from utcoffset() when relative-time helpers default other to now. A datetime can have tzinfo while remaining naive because its offset is None. Currently decimal_relative_time and relative_time pass that tzinfo to datetime.now(), which raises ValueError instead of applying the existing naive-UTC behavior.

Four regressions fail on unchanged master: text/numeric output for past/future datetimes with a None-returning tzinfo. Two controls retain ordinary naive/aware behavior. Full Python 3.12 tests/doctests: 780 passed, 1 platform skip, 22 passing subtests. Python 3.10 time tests/doctests: 30 passed. git diff --check passes. This applies the awareness distinction already used by dt_to_timestamp to a different public helper; no explicit-other behavior changes. Other systems/versions were not run locally.

The backstory

Previous contribution: #627. The account owner scheduled a batch of useful contributions. Found through source inspection and controlled regressions; no personal production incident is claimed.

AI assistance

  • Harness/tooling: OpenAI Codex.
  • Model(s): GPT-6-based Codex agent; exact serving identifier unavailable.
  • Original user prompt: “akta shedule task koro 4:42 am te new 20ta korbe..” (schedule a task for 4:42 AM to do 20 new contributions).
  • Scheduled instructions excerpt: “complete a new batch of 20 useful open-source contributions”; reproduce bugs, avoid overlapping work, test fixes and disclose AI assistance truthfully.

The agent investigated, implemented, tested and drafted this PR. No separate human code review is claimed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant