Repository navigation
Handle naive custom timezones in relative time defaults - #656
Open
ShahadatTest wants to merge 1 commit into
Open
ShahadatTest wants to merge 1 commit into
ShahadatTest wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change
Determine datetime awareness from utcoffset() when relative-time helpers default other to now. A datetime can have tzinfo while remaining naive because its offset is None. Currently decimal_relative_time and relative_time pass that tzinfo to datetime.now(), which raises ValueError instead of applying the existing naive-UTC behavior.
Four regressions fail on unchanged master: text/numeric output for past/future datetimes with a None-returning tzinfo. Two controls retain ordinary naive/aware behavior. Full Python 3.12 tests/doctests: 780 passed, 1 platform skip, 22 passing subtests. Python 3.10 time tests/doctests: 30 passed. git diff --check passes. This applies the awareness distinction already used by dt_to_timestamp to a different public helper; no explicit-other behavior changes. Other systems/versions were not run locally.
The backstory
Previous contribution: #627. The account owner scheduled a batch of useful contributions. Found through source inspection and controlled regressions; no personal production incident is claimed.
AI assistance
The agent investigated, implemented, tested and drafted this PR. No separate human code review is claimed.