Skip to content

fix(ode): initialize coeffs to zero in compute_coeffs #3300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucbv merged 1 commit into from
Oct 8, 2026
Merged

fix(ode): initialize coeffs to zero in compute_coeffs #3300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ode/impl/KokkosODE_BDF_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,11 @@ KOKKOS_FUNCTION void BDFStep(ode_type& ode, const table_type& table, scalar_type

template <class mat_type, class scalar_type>
KOKKOS_FUNCTION void compute_coeffs(const int order, const scalar_type factor, const mat_type& coeffs) {
// initialize coeffs
coeffs(0, 0) = 1.0;
for (int rowIdx = 0; rowIdx < order; ++rowIdx) {
coeffs(rowIdx + 1, 0) = 0.0;
}
for (int colIdx = 0; colIdx < order; ++colIdx) {
coeffs(0, colIdx + 1) = 1.0;
for (int rowIdx = 0; rowIdx < order; ++rowIdx) {
Expand Down
Loading