Conversation
Except for the first row, column zero of `coeffs` is left uninitialized. This isn't an issue if the user passes in a fresh View for `temp2` but if that View has been previously used or it's an unmanaged View then there's no guarantees that the memory will arrive properly initialized to zero. Assisted-by: Claude:fable-5 Signed-off-by: Robert Caddy <rcaddy@princeton.edu>
bcaddy
force-pushed
the
dev-init-to-zero
branch
from
September 14, 2026 15:45
a9e4712 to
8f12ab2
Compare
lucbv
approved these changes
Sep 14, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Except for the first row, column zero of
coeffsis left uninitialized. This isn't an issue if the user passes in a fresh View fortemp2but if that View has been previously used or it's an unmanaged View then there's no guarantees that the memory will arrive properly initialized to zero.Assisted-by: Claude:fable-5