Skip to content

Fixes a hang by separating error channels.#229

Merged
jeff-cohere merged 9 commits into
mainfrom
fix-hang-and-reported-errors
Jul 23, 2026
Merged

Fixes a hang by separating error channels.#229
jeff-cohere merged 9 commits into
mainfrom
fix-hang-and-reported-errors

Fixed an error channel issue with cancelling transfers.

0033e0a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 23, 2026 in 1s

59.14% (target 55.00%)

View this Pull Request on Codecov

59.14% (target 55.00%)

Details

Codecov Report

❌ Patch coverage is 56.41026% with 85 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.14%. Comparing base (95b5c78) to head (0033e0a).

Files with missing lines Patch % Lines
transfers/store.go 54.92% 25 Missing and 7 partials ⚠️
transfers/mover.go 55.26% 17 Missing ⚠️
transfers/dispatcher.go 61.53% 8 Missing and 2 partials ⚠️
transfers/manifestor.go 61.53% 10 Missing ⚠️
transfers/stager.go 66.66% 8 Missing ⚠️
transfers/transfers.go 25.00% 4 Missing and 2 partials ⚠️
transfers/errors.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   59.24%   59.14%   -0.10%     
==========================================
  Files          34       34              
  Lines        4615     4656      +41     
==========================================
+ Hits         2734     2754      +20     
- Misses       1564     1578      +14     
- Partials      317      324       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.