Skip to content

Fixes a hang by separating error channels.#229

Merged
jeff-cohere merged 9 commits into
mainfrom
fix-hang-and-reported-errors
Jul 23, 2026
Merged

Fixes a hang by separating error channels.#229
jeff-cohere merged 9 commits into
mainfrom
fix-hang-and-reported-errors

Conversation

@jeff-cohere

Copy link
Copy Markdown
Collaborator

The DTS has been getting a lot of transfer status requests, and this surfaced a few issues that were related to errors crossing in channels. Separating all the error pathways fixed the issues.

@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://kbase.github.io/dts/pr-preview/pr-229/

Built to branch gh-pages at 2026-07-23 21:39 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@jeff-cohere
jeff-cohere force-pushed the fix-hang-and-reported-errors branch from 7d81c6f to 0e9282c Compare July 21, 2026 18:47
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 56.41026% with 85 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.14%. Comparing base (95b5c78) to head (0033e0a).

Files with missing lines Patch % Lines
transfers/store.go 54.92% 25 Missing and 7 partials ⚠️
transfers/mover.go 55.26% 17 Missing ⚠️
transfers/dispatcher.go 61.53% 8 Missing and 2 partials ⚠️
transfers/manifestor.go 61.53% 10 Missing ⚠️
transfers/stager.go 66.66% 8 Missing ⚠️
transfers/transfers.go 25.00% 4 Missing and 2 partials ⚠️
transfers/errors.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   59.24%   59.14%   -0.10%     
==========================================
  Files          34       34              
  Lines        4615     4656      +41     
==========================================
+ Hits         2734     2754      +20     
- Misses       1564     1578      +14     
- Partials      317      324       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeff-cohere
jeff-cohere requested a review from mattldawson July 23, 2026 21:43

@mattldawson mattldawson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jeff-cohere
jeff-cohere merged commit a2b204c into main Jul 23, 2026
10 checks passed
@jeff-cohere
jeff-cohere deleted the fix-hang-and-reported-errors branch July 23, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants