Allow activate-only launcher use without hako-cmd - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make activate-only usable for process-only / Core-free launcher configurations without requiring
hako-cmd, while preserving the historicalhako-cmdpreflight for normal activation paths.This enables configurations such as:
before_starttoolsto run with:
without installing Hakoniwa Core or
hako-cmd.Compatibility boundary
The change is intentionally scoped to
activate-only.LauncherService.activate()keepsrequire_hako_cmd=Trueas the default, so direct callers and serve/immediate paths retain the existing behavior. Only the CLI/backgroundactivate-onlypath passesrequire_hako_cmd=False.A
readiness.type = hako_assetprobe still resolveshako-cmdlazily through the existing monitor/provider path.Existing activate-only users checked
A repository-wide search of the Hakoniwa organization found current activate-only usage in:
hakoniwa-mujoco-robotstb3-demo.bashtb3-mbody-demo.bashtb3-obstacle-avoidance-demo.bashhakoniwa-drone-proThe inspected launch files use activate-only to start
before_startprocesses without issuing the simulation start command. Their normal behavior is unchanged whenhako-cmdexists.The one intentional observable difference is failure behavior when
hako-cmdis absent:before_startprocesses;hako-cmdis required only if a Hakoniwa lifecycle command or hako_asset readiness probe is actually usedThat is the desired Core-free behavior.
Tests
Adds regression coverage that:
hako-cmdhako-cmdpreflight before starting assetsstartstill prepareshako-cmdThis is needed by the Core-free Zenoh Topology Viewer launcher flow.