Repository navigation
Conversation
deedeeh
added
the
maintenance
arelra
reviewed
Nov 5, 2026
arelra
reviewed
Nov 5, 2026
Contributor
deedeeh
commented
Nov 9, 2026
| "react-dom": "preact/compat", | ||
| }, | ||
| extensions: ['.js', '.ts', '.tsx', '.jsx'], | ||
| symlinks: false, // Inserted to enable linking @guardian/consent-management-platform |
Contributor
Author
There was a problem hiding this comment.
The webpack bundling was failing in the client-build CI before removing that line which Copilot helped to debug the issue but I believe this is still important and it requires to be added somewhere else?
I kept this line in another commit but I had to add nodeLinker: hoisted in order for the bundling in CI to pass.
What would be the best practice for the symlinks to be false? Do we even need to keep it that way?
| @@ -1,3 +1,4 @@ | |||
| nodeLinker: hoisted | |||
Contributor
Author
There was a problem hiding this comment.
This is required if we want to keep the symlinks: false in the webpack.config.js. Check doc for more info.
deedeeh
force-pushed
the
dina/migrate-from-yarn-to-pnpm
branch
from
November 9, 2026 10:00
458208f to
caa45b1
Compare
deedeeh
force-pushed
the
dina/migrate-from-yarn-to-pnpm
branch
from
November 9, 2026 14:54
caa45b1 to
a512489
Compare
deedeeh
marked this pull request as ready for review
November 9, 2026 15:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR migrates from the package manager from
yarntopnpmto align with the dotcom repositories and as a follow up PR we want to move fromactions/node-setuptopnpm/setuplike in here.Checklist