Skip to content

Don't fail framework start/stop on errors with plurl register/unregister #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjwatson merged 1 commit into from
Oct 1, 2026
Merged

Don't fail framework start/stop on errors with plurl register/unregister #1365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...eclipse.osgi/container/src/org/eclipse/osgi/internal/framework/SystemBundleActivator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,16 +83,16 @@ public void start(BundleContext bc) throws Exception {

equinoxContainer.systemStart(bc);

plurl = new PlurlImpl();
try {
plurl = new PlurlImpl();
plurl.install();
URLStreamHandlerFactoryImpl ushf = new URLStreamHandlerFactoryImpl(bc, equinoxContainer);
ContentHandlerFactoryImpl chf = new ContentHandlerFactoryImpl(bc, equinoxContainer);
Plurl.add(ushf);
plurlStreamHandlerFactory = ushf;
Plurl.add(chf);
plurlContentHandlerFactory = chf;
} catch (Exception e) {
} catch (Throwable e) {
// Don't fail framework launch if we cannot register with plurl.
// Any handler services will get ignored for this framework instance.
equinoxContainer.getLogServices().log(EquinoxContainer.NAME, FrameworkLogEntry.ERROR, e.getMessage(), e);
Expand Down Expand Up @@ -241,22 +241,22 @@ public void stop(BundleContext bc) throws Exception {
if (plurlStreamHandlerFactory != null) {
try {
Plurl.remove(plurlStreamHandlerFactory);
} catch (Exception e) {
} catch (Throwable e) {
bundle.getEquinoxContainer().getLogServices().log(EquinoxContainer.NAME, FrameworkLogEntry.ERROR,
e.getMessage(), e);
}
}
if (plurlContentHandlerFactory != null) {
try {
Plurl.remove(plurlContentHandlerFactory);
} catch (Exception e) {
} catch (Throwable e) {
bundle.getEquinoxContainer().getLogServices().log(EquinoxContainer.NAME, FrameworkLogEntry.ERROR,
e.getMessage(), e);
}
}
try {
plurl.uninstall();
} catch (Exception e) {
} catch (Throwable e) {
bundle.getEquinoxContainer().getLogServices().log(EquinoxContainer.NAME, FrameworkLogEntry.ERROR,
e.getMessage(), e);
}
Expand Down
Loading