Repository navigation
Don't fail framework start/stop on errors with plurl register/unregister - #1365
Merged
Merged
Conversation
In the OSGi TCK there was a test bug in their test class loader that loads the framework implementation. This caused Error to be thrown out of plurl. If this happens the framework should not fall down completely and fail to start or stop. This change makes sure we can recover if this happens and move on with the framework start/stop when an Error is thrown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the OSGi TCK there was a test bug in their test class loader that loads the framework implementation. This caused Error to be thrown out of plurl. If this happens the framework should not fall down completely and fail to start or stop.
This change makes sure we can recover if this happens and move on with the framework start/stop when an Error is thrown.