Skip to content

Fix live merged threads at the start #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
godlygeek merged 2 commits into from
Oct 17, 2026
Merged

Fix live merged threads at the start #1050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84a5200
tests: Check the live TUI table before toggling thread merging
kiri11 Oct 9, 2026
579c0fd
tui: Merge threads in the live table from the start
kiri11 Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/1050.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix the live mode TUI showing only the first thread's allocations until merging was toggled, even though it starts in merged mode.
2 changes: 1 addition & 1 deletion src/memray/reporters/tui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ class AllocationTable(Widget):
sort_column_id = reactive(default_sort_column_id)
snapshot = reactive(_EMPTY_SNAPSHOT)
current_thread = reactive(0)
merge_threads = reactive(False, init=False)
merge_threads = reactive(True, init=False)

columns = [
"Location",
Expand Down
6 changes: 3 additions & 3 deletions tests/unit/test_tui_reporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,7 +772,7 @@ async def run_test():

datatable = pilot.app.screen.query_one(DataTable)

for key in ("m", ">", "m", "<", "m", "<"):
for key in ("", "m", ">", "m", "<", "m", "<"):
await pilot.press(key)
functions.append(datatable.get_cell_at(Coordinate(0, 0)).plain)
labels = extract_label_text(app)
Expand All @@ -782,8 +782,8 @@ async def run_test():
async_run(run_test())

# THEN
order = [0, 1, 2, 2, 1, 0]
merged = [False, False, True, True, False, False]
order = [2, 0, 1, 2, 2, 1, 0]
merged = [True, False, False, True, True, False, False]
assert functions == ["abc"[i] for i in order]
assert tids == [
"TID: *" if all else f"TID: {hex(i + 1)}" for i, all in zip(order, merged)
Expand Down
Loading