Skip to content

Fix live merged threads at the start - #1050

Merged
godlygeek merged 2 commits into
bloomberg:mainfrom
kiri11:fix-live-merged-threads
Oct 17, 2026
Merged

godlygeek merged 2 commits into
bloomberg:mainfrom
kiri11:fix-live-merged-threads

Conversation

@kiri11

@kiri11 kiri11 commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Closes: #1045

Default AllocationTable.merge_threads to True, matching the screen.

Before:

Starting in Live mode shows only 1 thread despite claiming "All threads" at the top unless you press "m" twice.

After:

Live mode correctly merges all threads immediately after start.

Notes

This does not look intentional.
Added test that fails without this change.

The live TUI starts in merged mode, so its table should show every thread

Signed-off-by: Kirill Ignatev <kignatev@bloomberg.net>
@codecov-commenter

codecov-commenter commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.27%. Comparing base (060d7de) to head (579c0fd).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1050      +/-   ##
==========================================
- Coverage   92.31%   92.27%   -0.04%     
==========================================
  Files         103      103              
  Lines       13363    13363              
  Branches      483      483              
==========================================
- Hits        12336    12331       -5     
- Misses       1027     1032       +5     
Flag Coverage Δ
cpp 92.27% <100.00%> (-0.04%) ⬇️
python_and_cython 92.27% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kiri11
kiri11 marked this pull request as ready for review October 13, 2026 14:32
The table only showed the first thread until merging was toggled.

Signed-off-by: Kirill Ignatev <kignatev@bloomberg.net>
@godlygeek
godlygeek force-pushed the fix-live-merged-threads branch from 89811c4 to 579c0fd Compare October 17, 2026 19:55

@godlygeek godlygeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except I renamed the news entry to use the PR number instead of just calling it news/live-merged-threads.bugfix.rst - that way the changelog will include a link to the PR. I try to link to the PR whenever there's no issue to link to.

While reviewing this, I noticed that pilot.press("") doesn't actually seem to be defined to do nothing - but it's also an existing pattern we used elsewhere in the tests, so I think I'll send a separate PR to fix that everywhere where we've done it.

Also, I'm going to squash this one rather than rebase - I don't want a commit on main with a failing test, since it makes bisecting harder, so I'm going to squash the test and fix into one commit. Just an FYI, since we were talking about when to squash vs when to rebase yesterday 🙂

@godlygeek
godlygeek enabled auto-merge (squash) October 17, 2026 19:59
@godlygeek
godlygeek merged commit f332423 into bloomberg:main Oct 17, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Live mode table shows only the first thread although the header says “All threads”

3 participants