Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/verify.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: verify

on:
pull_request:
push:
branches: [master]

permissions:
contents: read

jobs:
verify:
uses: appwrite/renovate-config/.github/workflows/verify.yml@3afeb943b6d52145c7b5ebc6e74833bdf1ade094 # main

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide environment values for the SSR build

The shared workflow runs npm run build for server-side-rendering without setting its environment variables. That project declares PUBLIC_APPWRITE_ENDPOINT, PUBLIC_APPWRITE_PROJECT_ID, and APPWRITE_KEY as required static variables in src/env.ts, so SvelteKit fails the build when they are absent; this matches the failing verify / build server-side-rendering check and leaves the new CI red on every run.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/verify.yml
Line: 13

Comment:
**Provide environment values for the SSR build**

The shared workflow runs `npm run build` for `server-side-rendering` without setting its environment variables. That project declares `PUBLIC_APPWRITE_ENDPOINT`, `PUBLIC_APPWRITE_PROJECT_ID`, and `APPWRITE_KEY` as required static variables in `src/env.ts`, so SvelteKit fails the build when they are absent; this matches the failing `verify / build server-side-rendering` check and leaves the new CI red on every run.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟠 Major · bug · Reply if this doesn't apply.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid. The fix is in the demo rather than this workflow: #20 gives the three variables placeholder defaults in src/env.ts, so the build passes without a .env. Once #20 merges, this PR needs a rebase onto master or a re-run.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but this isn’t resolved in this PR yet: src/env.ts still declares all three variables as required, with no defaults (lines 3–6), and this workflow still passes no environment values (line 13). Please rebase or merge the fix from #20 into this PR and rerun verification; until then, the build failure remains possible.

Loading