Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide environment values for the SSR build
The shared workflow runs
npm run buildforserver-side-renderingwithout setting its environment variables. That project declaresPUBLIC_APPWRITE_ENDPOINT,PUBLIC_APPWRITE_PROJECT_ID, andAPPWRITE_KEYas required static variables insrc/env.ts, so SvelteKit fails the build when they are absent; this matches the failingverify / build server-side-renderingcheck and leaves the new CI red on every run.Prompt To Fix With AI
🟠 Major · bug · Reply if this doesn't apply.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid. The fix is in the demo rather than this workflow: #20 gives the three variables placeholder defaults in
src/env.ts, so the build passes without a.env. Once #20 merges, this PR needs a rebase onto master or a re-run.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but this isn’t resolved in this PR yet:
src/env.tsstill declares all three variables as required, with no defaults (lines 3–6), and this workflow still passes no environment values (line 13). Please rebase or merge the fix from #20 into this PR and rerun verification; until then, the build failure remains possible.