Repository navigation
ci: verify builds with the shared workflow - #19
ChiragAgg5k wants to merge 1 commit into
Conversation
🟡 Tier B · Needs changes before merging
Adds a GitHub Actions workflow for pull requests and pushes to
Fix with agent prompt### Issue 1
.github/workflows/verify.yml:13
**Provide environment values for the SSR build**
The shared workflow runs `npm run build` for `server-side-rendering` without setting its environment variables. That project declares `PUBLIC_APPWRITE_ENDPOINT`, `PUBLIC_APPWRITE_PROJECT_ID`, and `APPWRITE_KEY` as required static variables in `src/env.ts`, so SvelteKit fails the build when they are absent; this matches the failing `verify / build server-side-rendering` check and leaves the new CI red on every run.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 1
Reviewed |
|
|
||
| jobs: | ||
| verify: | ||
| uses: appwrite/renovate-config/.github/workflows/verify.yml@3afeb943b6d52145c7b5ebc6e74833bdf1ade094 # main |
There was a problem hiding this comment.
Provide environment values for the SSR build
The shared workflow runs npm run build for server-side-rendering without setting its environment variables. That project declares PUBLIC_APPWRITE_ENDPOINT, PUBLIC_APPWRITE_PROJECT_ID, and APPWRITE_KEY as required static variables in src/env.ts, so SvelteKit fails the build when they are absent; this matches the failing verify / build server-side-rendering check and leaves the new CI red on every run.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/verify.yml
Line: 13
Comment:
**Provide environment values for the SSR build**
The shared workflow runs `npm run build` for `server-side-rendering` without setting its environment variables. That project declares `PUBLIC_APPWRITE_ENDPOINT`, `PUBLIC_APPWRITE_PROJECT_ID`, and `APPWRITE_KEY` as required static variables in `src/env.ts`, so SvelteKit fails the build when they are absent; this matches the failing `verify / build server-side-rendering` check and leaves the new CI red on every run.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟠 Major · bug · Reply if this doesn't apply.
There was a problem hiding this comment.
Thanks, but this isn’t resolved in this PR yet: src/env.ts still declares all three variables as required, with no defaults (lines 3–6), and this workflow still passes no environment values (line 13). Please rebase or merge the fix from #20 into this PR and rerun verification; until then, the build failure remains possible.
|
Closing: #20 already added this same workflow file, so this PR has nothing left to add. |
This repository has no CI of its own, so Renovate PRs here are skipped by the org auto-merge rule as "repository has no CI".
This adds a caller for the shared verify workflow added in appwrite/renovate-config#12. It detects each project in the repository, installs it from the lockfile, and runs its build and test scripts when they exist. It runs with a read-only token and no secrets.
The reusable workflow is pinned by commit SHA, and Renovate keeps the pin up to date.