Skip to content

ci: verify builds with the shared workflow - #19

Closed
ChiragAgg5k wants to merge 1 commit into
masterfrom
ci/verify
Closed

ChiragAgg5k wants to merge 1 commit into
masterfrom
ci/verify

Conversation

@ChiragAgg5k

@ChiragAgg5k ChiragAgg5k commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

This repository has no CI of its own, so Renovate PRs here are skipped by the org auto-merge rule as "repository has no CI".

This adds a caller for the shared verify workflow added in appwrite/renovate-config#12. It detects each project in the repository, installs it from the lockfile, and runs its build and test scripts when they exist. It runs with a read-only token and no secrets.

The reusable workflow is pinned by commit SHA, and Renovate keeps the pin up to date.

@ghost

ghost commented Nov 3, 2026 •

Copy link
Copy Markdown

🟡 Tier B · Needs changes before merging

The new verification workflow currently fails on every run because the SSR build is missing required environment variables.

Adds a GitHub Actions workflow for pull requests and pushes to master, delegating project verification to the pinned shared workflow. The caller grants the reusable workflow read-only contents permission.

Verdict New comments Fixed Still open
🛑 Changes requested 1 0 0
Finding Where
🟠 Provide environment values for the SSR build .github/workflows/verify.yml:13
Fix with agent prompt
### Issue 1
.github/workflows/verify.yml:13
**Provide environment values for the SSR build**

The shared workflow runs `npm run build` for `server-side-rendering` without setting its environment variables. That project declares `PUBLIC_APPWRITE_ENDPOINT`, `PUBLIC_APPWRITE_PROJECT_ID`, and `APPWRITE_KEY` as required static variables in `src/env.ts`, so SvelteKit fails the build when they are absent; this matches the failing `verify / build server-side-rendering` check and leaves the new CI red on every run.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 1
File Change
.github/workflows/verify.yml Adds the shared verification workflow as a required CI entry point.

Reviewed 9ef4d8d · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Tier B · 1 blocking finding to address. Summary


jobs:
verify:
uses: appwrite/renovate-config/.github/workflows/verify.yml@3afeb943b6d52145c7b5ebc6e74833bdf1ade094 # main

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide environment values for the SSR build

The shared workflow runs npm run build for server-side-rendering without setting its environment variables. That project declares PUBLIC_APPWRITE_ENDPOINT, PUBLIC_APPWRITE_PROJECT_ID, and APPWRITE_KEY as required static variables in src/env.ts, so SvelteKit fails the build when they are absent; this matches the failing verify / build server-side-rendering check and leaves the new CI red on every run.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/verify.yml
Line: 13

Comment:
**Provide environment values for the SSR build**

The shared workflow runs `npm run build` for `server-side-rendering` without setting its environment variables. That project declares `PUBLIC_APPWRITE_ENDPOINT`, `PUBLIC_APPWRITE_PROJECT_ID`, and `APPWRITE_KEY` as required static variables in `src/env.ts`, so SvelteKit fails the build when they are absent; this matches the failing `verify / build server-side-rendering` check and leaves the new CI red on every run.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟠 Major · bug · Reply if this doesn't apply.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid. The fix is in the demo rather than this workflow: #20 gives the three variables placeholder defaults in src/env.ts, so the build passes without a .env. Once #20 merges, this PR needs a rebase onto master or a re-run.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but this isn’t resolved in this PR yet: src/env.ts still declares all three variables as required, with no defaults (lines 3–6), and this workflow still passes no environment values (line 13). Please rebase or merge the fix from #20 into this PR and rerun verification; until then, the build failure remains possible.

@ChiragAgg5k

Copy link
Copy Markdown
Member Author

Closing: #20 already added this same workflow file, so this PR has nothing left to add.

@ChiragAgg5k ChiragAgg5k closed this Nov 3, 2026
@ChiragAgg5k
ChiragAgg5k deleted the ci/verify branch November 3, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant