Skip to content

branch-4.1: [fix](variant) Write Variant V2 sparse keys in byte order - #70189

Merged
eldenmoon merged 1 commit into
apache:branch-4.1from
eldenmoon:branch-pick-70001-4.1-20261103
Nov 10, 2026
Merged

eldenmoon merged 1 commit into
apache:branch-4.1from
eldenmoon:branch-pick-70001-4.1-20261103

Conversation

@eldenmoon

Copy link
Copy Markdown
Member

cherry-pick #70001

Test adaptation: branch-4.1 defaults enable_variant_v2=false, so the regression case now temporarily enables it via setFeConfigTemporary (suite marked nonConcurrent) and additionally asserts variant_type(v); expected outputs are otherwise unchanged.

@eldenmoon
eldenmoon requested a review from yiguolei as a code owner November 4, 2026 07:30
@eldenmoon

Copy link
Copy Markdown
Member Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 61.84% (27319/44175)
Line Coverage 46.54% (285156/612761)
Region Coverage 42.14% (225679/535483)
Branch Coverage 43.74% (105235/240565)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 75.27% (32337/42963)
Line Coverage 59.72% (363033/607873)
Region Coverage 56.32% (302152/536531)
Branch Coverage 57.33% (137748/240262)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants