Repository navigation
Conversation
Contributor
|
run cloudut |
Member
Author
|
run external |
Member
Author
|
run beut |
Member
Author
|
run feut |
CIR-22588: compaction promotes sparse paths to materialized subcolumns by a raw-byte lower_bound. Sparse keys written in component order were missed, filled with NULL, and removed from sparse, so the non-null values disappeared from the output file. The writer now publishes byte-ordered sparse keys; this suite verifies that after a full compaction the promoted tag_id/tag_name values are still present, using the customer's six-row shape and control rows.
eldenmoon
force-pushed
the
branch-cir22588-41-tests
branch
from
November 12, 2026 02:10
e5c34b5 to
ff59663
Compare
Member
Author
|
run buildall |
Member
Author
|
run p0 |
Member
Author
|
run cloud_p0 |
Member
Author
|
run vault_p0 |
Member
Author
|
run external |
Member
Author
|
run nonConcurrent |
Member
Author
|
run external |
1 similar comment
Member
Author
|
run external |
Member
Author
|
run nonConcurrent |
Member
Author
|
run cloud_p0 |
Member
Author
|
run compile |
Member
Author
|
run feut |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
CIR-22588: after a full compaction, a VARIANT row's non-null sparse values (
tag-labeling.text_info.open.tag_id/tag_name) became NULL in the materialized subcolumns and were removed from sparse, so the values disappeared from the output segment. The byte-ordered sparse writer (#70189) prevents the unordered input that made the compaction's raw-byte lookup miss the values.What does this PR do?
Cherry-pick the test-only change from the master PR #70435 to branch-4.1. No production code change.
The suite writes the customer's six-row shape into a V2 table with
variant_max_subcolumns_count=2, runs a full compaction, and asserts that row 1 still returnstag_id/tag_name/the parent object after compaction, with control rows 3/4 intact. It forcesenable_variant_v2=true, since the issue is specific to the V2 sparse Map.Verification