Skip to content

chore: fix clippy assert_is_empty lints - #110

Merged
abemedia merged 1 commit into
masterfrom
chore--fix-clippy-assert_is_empty-lints
Oct 4, 2026
Merged

abemedia merged 1 commit into
masterfrom
chore--fix-clippy-assert_is_empty-lints

Conversation

@abemedia

@abemedia abemedia commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Tests
    • Updated coverage to verify that empty input produces exactly one empty chunk.
    • Refined integration checks for stash cleanup and recovery across interruption, tracked-file restoration, closed output, and empty-repository scenarios. No user-facing behavior changes are included in this update.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 1b613ca8-cdf2-42a8-855a-30116e8620b2
📥 Commits

Reviewing files that changed from the base of the PR and between a4e846e and 0962a7e.

📒 Files selected for processing (2)
  • src/runner.rs
  • tests/integration.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The empty-file test now checks for exactly one empty slice. Integration tests update assertions for stash-list output and sparse-checkout index entries.

Changes

Test expectation updates

Layer / File(s) Summary
Update test assertions
src/runner.rs, tests/integration.rs
The empty-file test checks for one empty slice. Integration tests compare stash-list output with an empty string and check sparse-checkout index entries against an empty string.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 0962a

These test-only changes preserve the existing expectations and introduce no actionable merge risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the changes: tests now use assertions that avoid Clippy’s assert_is_empty lint.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 2 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
stagelint-docs 0962a7e Commit Preview URL

Branch Preview URL
Oct 04 2026, 12:21 AM

@abemedia
abemedia merged commit 7808b82 into master Oct 4, 2026
6 checks passed
@abemedia
abemedia deleted the chore--fix-clippy-assert_is_empty-lints branch October 4, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant