Skip to content

fix: reject overlong Rabin-Karp patterns #3261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devam007 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: reject overlong Rabin-Karp patterns #3261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions strings/rabin_karp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
*/
#include <cassert>
#include <cmath>
#include <cstdint>
#include <iostream>
#ifdef _MSC_VER
#include <string> // use this for MS Visucal C++
Expand Down Expand Up @@ -81,6 +82,10 @@ bool check_if_equal(const std::string& str1, const std::string& str2,
*/

int rabin_karp(const std::string& str, const std::string& pat) {
if (pat.size() > str.size()) {
return -1;
}

int64_t pat_hash = create_hash(pat, pat.size());
int64_t str_hash = create_hash(str, pat.size());
for (int i = 0; i <= str.size() - pat.size(); ++i) {
Expand All @@ -103,6 +108,10 @@ using string_search::rabin_karp;

/** Main function */
int main(void) {
assert(rabin_karp("a", "abcdef") == -1);
assert(rabin_karp("", "a") == -1);
assert(rabin_karp("", "") == 0);
assert(rabin_karp("abc", "abc") == 0);
assert(rabin_karp("helloWorld", "world") == -1);
assert(rabin_karp("helloWorld", "World") == 5);
assert(rabin_karp("this_is_c++", "c++") == 8);
Expand Down