Repository navigation
Conversation
devam007
requested review from
Panquesito7 and
realstealthninja
as code owners
October 23, 2026 18:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Return -1 before hashing when the pattern is longer than the text. Previously,
the initial hash accessed characters beyond the text, and the unsigned length
subtraction could underflow. Add the required cstdint header for the existing
int64_t declarations and four assertions for overlong, empty and exact-match
inputs. The hash algorithm and other behavior are unchanged.
Validation
GCC 15.2 / C++17: 16,066 reference comparisons pass against std::string::find,
including exhaustive binary-alphabet texts through length seven and patterns
through length five. The overlong-pattern reproduction fails on the base with
libstdc++ assertions enabled. The CMake/Ninja target, source assertions and
git diff --check pass. Existing signedness warnings remain. This patch does not
redesign integer hashing or establish safety for arbitrarily long patterns.
Remote CI, clang-format and clang-tidy were not run locally.