Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #200.
Ignore
CPY001as requested and moveNoneto the end of the two unions flagged byRUF036in the mixed-value sorting test. Ruff 0.16.8 also reportsPLR0917for two functions that already have localPLR0913exemptions; extend those exemptions to cover positional argument counts while preserving their signatures.Validation on Python 3.12 / Ubuntu 24.04:
ruff check: 38 diagnostics before (34CPY001, twoRUF036, twoPLR0917), none after, using Ruff 0.16.8.ruff format --check: all 42 files pass.pytest --hypothesis-profile=slow-tests --tb=short --cov natsort --cov-report term-missing: 355 passed. The same 355 tests also passed before the changes.python -m doctest -o IGNORE_EXCEPTION_DETAIL docs/howitworks.rst: passed.pytest README.rst docs/examples.rst: passed.pytest --doctest-modules natsort: 14 passed.mypy --strict natsort tests: no issues in 32 source files.python -m buildandtwine check dist/*: source distribution and wheel pass.AI disclosure: This change was prepared and tested with OpenAI Codex.