Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
=======================================
Coverage 97.80% 97.80%
=======================================
Files 10 10
Lines 637 637
=======================================
Hits 623 623
Misses 14 14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
|
There is still a failure with ICN001 (see https://github.com/SethMMorton/natsort/actions/runs/36879900937/job/116774583287?pr=203). Feel free to update |
Owner
|
A lot of tests are now failing because 3.9 has been removed from CI. If you are interested, can you update the CI configuration to remove 3.9, and for the things that were using 3.9 use 3.10 now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #200.
This adds
CPY001to the ignore list as requested and putsNonelast in the two type unions flagged byRUF036.Ruff 0.16.9 also flags two functions for having too many positional arguments (
PLR0917). Both already have aPLR0913exception for their argument counts, so this extends those same exceptions without changing the function signatures.This follows the approach in the closed PR #202, with the checks rerun against current main.
On macOS with Python 3.10.20, Ruff goes from 38 errors to zero. All 355 tests pass both before and after the change. Formatting, doctests, strict mypy checks, and package build/validation also pass.
Codex helped with the changes and testing.