Restore Chinese part captions — the published ToC has been English for 17 days - #245
Merged
Conversation
The published Chinese site has been serving 19 English section captions and zero Chinese ones since 84fbaca (#202, 2026-07-24), which replaced the edition's 14 hand-set Chinese captions with the English source's as part of a full-ToC mirror regeneration. Seventeen days live. This is not a revert of 84fbaca. Upstream restructured the parts in the same change, so the caption set went 14 -> 19: it dissolved the old 消费、储蓄与资本 part four ways (cass_* -> Optimal Growth, os_* -> Introduction to Optimal Savings, ifp_* -> Household Problems, and ak2 moved out to Multiple Agent Models), and split three lectures out of Search into a new Reinforcement Learning part. So 13 captions are restored verbatim from f8bf219 and 6 are new; the retired caption is not recycled, because no successor part carries its scope. Every new caption is a phrase this edition already uses for the same English string, not a fresh coinage: - 强化学习 inventory_q.md:514, prospects_bounded_rationality.md:539 - 最优储蓄导论 os.md:11/:28 -- the part's own lead-lecture title - 家庭问题 ifp_discrete.md:34, and the heading-map pairs in cass_koopmans_2.md:21 and ak_aiyagari.md:28 - 宏观经济学中的有限理性 prospects_bounded_rationality.md:55, rendering Sargent (1993), whose title is the English caption - 菲利普斯曲线权衡 phillips_lost_conquest.md:53, which already names this very suite - 最优增长 cass_koopmans_1.md:44, describing the part's subject Bridge repair, not a durable fix: _toc.yml is regenerated as a full source mirror by lecture-adding syncs, so the next one reverts this. No open sync PR touches _toc.yml today, so the window is clear. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Durable fix filed as QuantEcon/action-translation#254 — sync overwrites localised |
There was a problem hiding this comment.
Pull request overview
Restores Chinese part captions in lectures/_toc.yml so the published zh-cn site navigation shows localized section titles instead of the English originals.
Changes:
- Replaces 19 English
parts[].captionvalues inlectures/_toc.ymlwith Chinese captions to match the zh-cn edition.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - file: os_egm | ||
| - file: os_egm_jax | ||
| - caption: Household Problems | ||
| - caption: 家庭问题 |
✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
@HumphreyYang I am going to merge this as is. But let me know what you think re: contested translations. Then if we need to update the glossary we can do so on action-translation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published Chinese site has been serving 19 English section captions and zero Chinese ones since #202 merged on 2026-07-24 — seventeen days live on the flagship Chinese edition. This restores them.
What happened
#202 (
84fbaca) regeneratedlectures/_toc.ymlas a full mirror of the English source, which carried the English captions over the 14 hand-set Chinese ones. The reviewer scored that PRPASS, 9/9/9/9, all four diff-checks true, withrecommendationReasons: []— a prose-quality reviewer does not see a structural de-localisation, which is why nothing flagged it.This is not a revert
Upstream restructured the parts in the same change, so the caption set went from 14 to 19. The old
消费、储蓄与资本part held 16 lectures and was dissolved four ways:cass_koopmans_1/2,cass_fiscal,cass_fiscal_2os_*ifp_*ak2Three lectures also moved out of Search into a new Reinforcement Learning part. So 13 captions are restored verbatim from
f8bf219(#202's parent) and 6 are new. The retired消费、储蓄与资本is not recycled — no successor part carries its scope, so reusing it would mislabel a section. 14 − 1 + 6 = 19, matching the English caption count exactly.The six new captions are attested, not coined
Each is a phrase this edition already uses for the same English string:
强化学习inventory_q.md:514,prospects_bounded_rationality.md:539最优储蓄导论os.md:11and:28— the part's own lead-lecture title家庭问题ifp_discrete.md:34("这个储蓄问题通常被称为收入波动问题或家庭问题"), plus heading-map pairs atcass_koopmans_2.md:21andak_aiyagari.md:28; 29 occurrences across 11 files宏观经济学中的有限理性prospects_bounded_rationality.md:55, rendering Sargent (1993) — whose title is the English caption菲利普斯曲线权衡phillips_lost_conquest.md:53, which already names this very suite最优增长cass_koopmans_1.md:44, describing the part's own subjectX导论for "Introduction to X" follows this repo's own lost caption动态系统导论← "Introduction to Dynamics".其他is kept at position 19 — this repo's form; lecture-intro.zh-cn uses其它and the two were deliberately not harmonised here.🟡 One call for @HumphreyYang
Household Problems →
家庭问题, or收入波动问题? This was the one genuinely contested choice.家庭问题translates the English caption and is what the part's own lead lecture calls its subject. But all five member lectures are titled收入波动问题 I–V, so under家庭问题the caption shares no character with any page title beneath it, and bare家庭问题has an everyday reading ("family troubles") that prose disambiguates but a navigation label does not.Both are defensible —
ifp_discrete.md:34explicitly equates the two names. This is a traceability-versus-clarity judgement rather than a correctness question, so it should be yours. Happy to swap it at position 10 if you prefer the series name.Also worth a second opinion, though not contested:
Optimal Growth → 最优增长versus最优增长模型. The bare form was chosen because the English caption is bare and the part also covers competitive equilibrium and fiscal policy, but多主体模型shows模型does appear in this repo's captions.Scope and durability
The diff is 19 caption lines and nothing else — 19 insertions, 19 deletions, zero non-caption changed lines. No YAML quoting is needed (no ASCII colons). The trailing space on the old
"Statistics and Information "is not carried over.This is a bridge repair, not a durable fix.
_toc.ymlis regenerated as a full source mirror by lecture-adding syncs, so the next one reverts it — the same mechanism that caused this. Nothing enforces caption language today: the engine reads_toc.ymlonly for lecture discovery and no mode emits a translated caption, so review mode's gatingterminologycategory never sees a caption regression. Filed for the durable fix. No open sync PR touches_toc.ymlright now, so the window is clear.Once merged this needs a publish tag to reach readers; verify after the ~10-minute Pages CDN window.
🤖 Generated with Claude Code