Skip to content

fix port number truncation in httpSeparateURI #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelrsweet merged 1 commit into from
Oct 15, 2026
Merged

fix port number truncation in httpSeparateURI #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ v3.0.4 - YYYY-MM-DD
- Fixed some character testing that wasn't safe on platforms with a signed
`char` type (Issue #177)
- Fixed support for mDNSResponder on Windows (Issue #178)
- Fixed `httpSeparateURI` to reject URI port numbers whose value was truncated
when converted to `int`.


v3.0.3 - 2026-08-20
Expand Down
8 changes: 6 additions & 2 deletions cups/http-support.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,21 +938,25 @@ httpSeparateURI(
// See if we have a port number...
if (*uri == ':')
{
long portnum; // Port number

// Yes, collect the port number...
if (!_cups_isdigit(uri[1]))
{
*port = 0;
return (HTTP_URI_STATUS_BAD_PORT);
}

*port = (int)strtol(uri + 1, (char **)&uri, 10);
portnum = strtol(uri + 1, (char **)&uri, 10);

if (*port <= 0 || *port > 65535)
if (portnum <= 0 || portnum > 65535)
{
*port = 0;
return (HTTP_URI_STATUS_BAD_PORT);
}

*port = (int)portnum;

if (*uri != '/' && *uri)
{
*port = 0;
Expand Down
3 changes: 3 additions & 0 deletions cups/testhttp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,9 @@ static uri_test_t uri_tests[] = // URI test data
{ HTTP_URI_STATUS_BAD_PORT, "http://127.0.0.1:9999a/index.html",
"http", "", "127.0.0.1", "", 0, 0,
HTTP_URI_CODING_MOST },
{ HTTP_URI_STATUS_BAD_PORT, "http://127.0.0.1:4294967377/index.html",
"http", "", "127.0.0.1", "", 0, 0,
HTTP_URI_CODING_MOST },

// Bad resource
{ HTTP_URI_STATUS_BAD_RESOURCE, "mailto:\r\nbla",
Expand Down
Loading