Repository navigation
fix port number truncation in httpSeparateURI - #179
Merged
michaelrsweet merged 1 commit intoOct 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpSeparateURI collects the port portion of a URI with
*port = (int)strtol(uri + 1, ...), so the range check that follows runs on the already-truncatedint. On 64-bit platforms a numeric port of 2^32+N truncates to N, and a URI such asipp://host:4294967953/ipp/printcomes back asHTTP_URI_STATUS_OKwith port 657 instead ofHTTP_URI_STATUS_BAD_PORT, whilehttp://127.0.0.1:99999/is rejected as expected. URIs that land here are often remote input, for exampleprinter-uri-supportedvalues from an IPP printer or endpoint URLs from OAuth server metadata, so this parser and a strict RFC 3986 parser disagree about the same string. Keeping thestrtolresult in alongand checking the range before narrowing restores the rejection for out-of-range values of any size. Added a testhttp case under the bad-port entries that returns OK with port 81 before the change and BAD_PORT after;make teststill passes with a 100% score.