Skip to content

Even further simplify - #726

Draft
mcarans wants to merge 4 commits into
OoliteProject:masterfrom
mcarans:even_further_simplify
Draft

Even further simplify#726
mcarans wants to merge 4 commits into
OoliteProject:masterfrom
mcarans:even_further_simplify

Conversation

@mcarans

@mcarans mcarans commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

#725 +
move setUpBasicOpenGLStateWithSize from GameController.m to MyOpenGLVIew.m
make common updateGLSize function called by resize and initialiseGLwithSize
Move the related methods to be next to each other in the source for readability

@phkb @LW-archlinux If this works then I won't need to merge 725

@mcarans

mcarans commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

@phkb in addition can you try what's suggested here? https://discourse.libsdl.org/t/how-to-go-fullscreen-in-sdl3-without-ws-popup/69148/4 (ie. remove the Windows hack and instead hide the SDL window, call SDL_SetWindowFullscreen and show the window) then see if you get the 5 second delay when switching between window and fullscreen. Funnily enough this is the trick required to centre the game window after splash on Wayland on Linux.

SDL_HideWindow(window);
SDL_SetWindowFullscreen(window, fullScreen);
SDL_ShowWindow(window);

@mcarans
mcarans marked this pull request as draft August 23, 2026 23:29
@mcarans

mcarans commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

Setting to draft while I investigate failure on master

@phkb

phkb commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

The code in the PR is fine, tested OK, no pauses. However, attempting to remove the hack and do the hide/setWindowFullScreen/show thing still caused delays.

@mcarans

mcarans commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

The code in the PR is fine, tested OK, no pauses. However, attempting to remove the hack and do the hide/setWindowFullScreen/show thing still caused delays.

Thanks for testing. I have reported that hide/show didn't work: https://discourse.libsdl.org/t/how-to-go-fullscreen-in-sdl3-without-ws-popup/69148/5

I will have to rebase this PR assuming the fix I've made helps resolve Linux startup issues (#727)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants