Even further simplify - #726
Conversation
|
@phkb in addition can you try what's suggested here? https://discourse.libsdl.org/t/how-to-go-fullscreen-in-sdl3-without-ws-popup/69148/4 (ie. remove the Windows hack and instead hide the SDL window, call SDL_SetWindowFullscreen and show the window) then see if you get the 5 second delay when switching between window and fullscreen. Funnily enough this is the trick required to centre the game window after splash on Wayland on Linux. |
|
Setting to draft while I investigate failure on master |
|
The code in the PR is fine, tested OK, no pauses. However, attempting to remove the hack and do the hide/setWindowFullScreen/show thing still caused delays. |
Thanks for testing. I have reported that hide/show didn't work: https://discourse.libsdl.org/t/how-to-go-fullscreen-in-sdl3-without-ws-popup/69148/5 I will have to rebase this PR assuming the fix I've made helps resolve Linux startup issues (#727) |
#725 +
move setUpBasicOpenGLStateWithSize from GameController.m to MyOpenGLVIew.m
make common updateGLSize function called by resize and initialiseGLwithSize
Move the related methods to be next to each other in the source for readability
@phkb @LW-archlinux If this works then I won't need to merge 725